Skip to content

Support Differential for NI hardware's analog inputs as fallback #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Support Differential for NI hardware's analog inputs as fallback #2486

wants to merge 7 commits into from

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Aug 12, 2025 •
edited
Loading

Close #2484

Close #2472

@t-b
Copy link
Collaborator Author

t-b commented Aug 12, 2025

@timjarsky Ready to test!

@timjarsky
Copy link
Collaborator

Zayd is testing. I gave him the installer today.

@timjarsky timjarsky assigned t-b and unassigned timjarsky Aug 20, 2025
@timjarsky
Copy link
Collaborator

@t-b , from Zayd:

  If available we will fallback to Differential (Diff), see also https://knowledge.ni.com/KnowledgeArticleDetails?id=kA00Z0000019QRZSA2.
  !!! Threadsafe assertion FAILED !!!
  Message: "Start acquisition of NI device Dev1 failed with code: 65552
DAQmx_Scan;Expected channel type keyword: 'DIFF', 'NRSE', or 'RSE'.
While executing DAQmx_Scan:NIDAQ Tools error for device Dev1:10016: Expected channel type keyword: 'DIFF', 'NRSE', or 'RSE'."
  Please provide the following information if you contact the MIES developers:
  ################################
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  Stacktrace:
  DAP_ButtonProc_TPDAQ(...)#L3947 [MIES_DAEphys.ipf]
TPM_StartTestPulseMultiDevice(...)#L68 [MIES_TestPulse_Multi.ipf]
TPM_StartTPMultiDeviceLow(...)#L42 [MIES_TestPulse_Multi.ipf]
TPM_BkrdTPMD(...)#L87 [MIES_TestPulse_Multi.ipf]
HW_StartAcq(...)#L668 [MIES_DAC-Hardware.ipf]
HW_NI_StartAcq(...)#L2322 [MIES_DAC-Hardware.ipf]
FATAL_ERROR(...)#L336 [MIES_Utilities_ProgramFlow.ipf]
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  Time: 2025-08-20T16:38:25-04:00
  Experiment: Untitled ()
  Igor Pro version: 9.0.6.1 (56565)
  ################################

@t-b
Copy link
Collaborator Author

t-b commented Aug 22, 2025

@timjarsky Thanks for testing. Should be fixed now. Please retest.

@t-b t-b assigned timjarsky and unassigned t-b Aug 22, 2025
@t-b t-b force-pushed the feature/2486-allow-different-ADC-methods-for-NI branch from 088c100 to a247f58 Compare September 3, 2025 18:34
t-b added 7 commits September 30, 2025 17:25
@t-b
HW_NI_DIFFERENTIAL_SETUP: Add comment
df68593
@t-b
HW_NI_PrepareAcq: Prefer constant and stringifier
d6c3bc5 
In a future commit we want to make it configurable.
@t-b
HW_PrepareAcq: Add support for selecting a supported ADC configuration
2308963 
Add an ADCConfig parameter which allows to pass in the output from
HW_NI_GetAnalogInputConfig.

We now only use RSE if it is supported and fallback to Differential if
available. If that is also not available we bail out.
@t-b
HW_NI_PrintPropertiesOfDevices: Include ADC configuration bits
11e49e4 
We want that information in the issue template as well and
MEN_CreateIssueOnGithub() uses this function.
@t-b
DA_Ephys: Support data acquisition with NI hardware without RSE support
d018b46 
Up to now we only supported configuring ADC channels with RSE when using
NI hardware. Although this is the preferred configuration [1] some NI
hardware does not support that.

We have a user report now that hacked-in Differential support works, so let's
fallback to that with a message.

The available ADC configurations are also stored in the labnotebook.

[1]: https://knowledge.ni.com/KnowledgeArticleDetails?id=kA00Z0000019QRZSA2
@t-b
README.md: Update regarding RSE/Diff for NI hardware
c29acd0
@t-b
HW_NI_AnalogInputToString: Use correct string representations
184256c 
We need to use the names accepted by the NIDAQ MX operations and functions.
See for example the help for DAQmx_AI_SetupReader.
@t-b t-b force-pushed the feature/2486-allow-different-ADC-methods-for-NI branch from a247f58 to 184256c Compare October 1, 2025 00:25
@t-b
Copy link
Collaborator Author

t-b commented Oct 2, 2025

@timjarsky Any update from Zayd?

@timjarsky
Copy link
Collaborator

He continues to be unable to get his NI hardware to work with this PR (the hack did work)

@t-b t-b assigned t-b and unassigned timjarsky Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timjarsky timjarsky Awaiting requested review from timjarsky timjarsky is a code owner

@MichaelHuth MichaelHuth Awaiting requested review from MichaelHuth MichaelHuth is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@t-b t-b

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support different AD input methods for NI hardware Clarify NI device support for devices without RSE

2 participants

@t-b @timjarsky