-
-
Notifications
You must be signed in to change notification settings - Fork 111
Modification in header of the project for better UI #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…pand in header now because in expanded version the components overlap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for your PR.
review the comment please
| const handleLogout = () => { | ||
| localStorage.removeItem('token'); | ||
| localStorage.removeItem('userData'); | ||
| localStorage.removeItem("token"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
if you want to do formatting fixes then please do it on whole project also better to create a editor rule file and add the rules there or add eslint config file. ESLint will do all formatting changes in one go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thank you for the suggestion. I will configure ESLint rules for consistent formatting instead of fixing it file by file.
|
@Akanksha6209127 This branch has conflicts that must be resolved |
…pand in header now because in expanded version the components overlap.
…InfantCareCompass into new # Conflicts: # client/src/components/Header.jsx


I try to made cleaner version for header section, increase the size of left side icon, add merge all the components of header in hamburger menu for desktop. Sign In, Dark/Light toggle button and Get Started is not added in hamburger menu it is directly shown in header section. I also change the position of Moon icon in toggle button of Dark/Light theme. These changes made a clean and better UI and it is easy to use and no any components are overlapped.



These following images shows the changes in features of UI.
Before:-
After:-
These Images shows the difference and changes. Please check the code.