-
-
Notifications
You must be signed in to change notification settings - Fork 111
Modification in header of the project for better UI #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Akanksha6209127
wants to merge
23
commits into
Amarjha01:master
Choose a base branch
from
Akanksha6209127:new
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
b6aa6e3
All the components are in Hamburg menu for desktop mode. It is not ex…
Akanksha6209127 126775f
I remove all the unusual comments.
Akanksha6209127 0f87583
Formattinh of code and remove all unusual comments.
Akanksha6209127 d18df43
The conflict arises due to formatting is resolved in Header file.
Akanksha6209127 2a82a3f
Merge conflict is resolution.
Akanksha6209127 3d84658
I try to resolve conflict
Akanksha6209127 ae1d318
...
Akanksha6209127 4d2ed6b
Merge branch 'new' of https://github.com/Akanksha6209127/InfantCareCo…
Akanksha6209127 cf32f36
..
Akanksha6209127 bf43b14
Merge branch 'master' into new
Akanksha6209127 f057b40
Try to resole merge conflict.
Akanksha6209127 2f25088
All the components are in Hamburg menu for desktop mode. It is not ex…
Akanksha6209127 f213983
I remove all the unusual comments.
Akanksha6209127 7310777
Formattinh of code and remove all unusual comments.
Akanksha6209127 03bb0d5
The conflict arises due to formatting is resolved in Header file.
Akanksha6209127 c499794
I try to resolve conflict
Akanksha6209127 7395e2e
...
Akanksha6209127 00a0f5d
Merge conflict is resolution.
Akanksha6209127 9733b58
..
Akanksha6209127 5be957a
Try to resole merge conflict.
Akanksha6209127 93a19cd
Merge branches 'new' and 'new' of https://github.com/Akanksha6209127/…
Akanksha6209127 b098116
Fix header layout and adjust spacing for Get Started button
Akanksha6209127 3134112
Resolved merge conflict in Header.jsx
Akanksha6209127 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
if you want to do formatting fixes then please do it on whole project also better to create a editor rule file and add the rules there or add eslint config file. ESLint will do all formatting changes in one go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thank you for the suggestion. I will configure ESLint rules for consistent formatting instead of fixing it file by file.