feat: allow configuring accounts to show full calldata when signing #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Feb 19, 2025
antazoey
force-pushed
the
feat/config-show-full-data
branch
from
1be0350 to
26e14d1
Compare
antazoey
commented
Feb 19, 2025
|
|
||
| class CalldataRepr(str, Enum): | ||
| full = "full" | ||
| abridged = "abridged" |
There was a problem hiding this comment.
I plan to add "decoded" here and it will attempt to decode the calldata if possible
There was a problem hiding this comment.
decoded would be amazing tbh
@BowTiedDevil was saying the same yesterday
3 tasks
fubuloubu
reviewed
Feb 20, 2025
| return self.to_string() | ||
|
|
||
| def to_string( | ||
| self, calldata_repr: Optional[Union[Literal["full"], Literal["abridged"]]] = None |
There was a problem hiding this comment.
Can this use CalldataRepr enum?
fubuloubu
reviewed
Feb 20, 2025
|
|
||
|
|
||
| @register(Config) | ||
| def config_class(): |
There was a problem hiding this comment.
Wonder if this instead should be a "core config" item, e.g.
display:
transactions: abridgedThere was a problem hiding this comment.
Mostly since behavior isn't just limited to ape-accounts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Checklist