Skip to content

Implement simplified IFU mode with cube readout #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teutoburg merged 33 commits into from
May 22, 2025

Prevent unexpected keyword argument, add logging

6635d92
Select commit
Loading
Failed to load commit list.
Merged

Implement simplified IFU mode with cube readout #654

Prevent unexpected keyword argument, add logging
6635d92
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 21, 2025 in 1s

76.82% (+0.15%) compared to 934f2ac

View this Pull Request on Codecov

76.82% (+0.15%) compared to 934f2ac

Details

Codecov Report

Attention: Patch coverage is 93.52941% with 11 lines in your changes missing coverage. Please review.

Project coverage is 76.82%. Comparing base (934f2ac) to head (6635d92).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
scopesim/effects/binning_3d.py 83.87% 5 Missing ⚠️
scopesim/optics/image_plane_utils.py 92.59% 2 Missing ⚠️
scopesim/optics/optical_train.py 71.42% 2 Missing ⚠️
scopesim/effects/detector_list.py 98.71% 1 Missing ⚠️
scopesim/effects/psfs/discrete.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   76.67%   76.82%   +0.15%     
==========================================
  Files          70       71       +1     
  Lines        8612     8717     +105     
==========================================
+ Hits         6603     6697      +94     
- Misses       2009     2020      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov