Implement simplified IFU mode with cube readout #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cost me almost an hour to figure out why nothing was coming through -.- I thought we already had a warning like this somewhere?
Closed
teutoburg
added
the
enhancement
This was never used anywhere except in testing and is likely a leftover from pre-ScopeSim days.
Now that `add_imagehdu_to_imagehdu()` can handle the 3D case, it needs a full WCS in such a case. I don't think there's a reason to not add the spectral part at this point already.
This eliminated the need to have a spectral trace list effect in the simple IFU mode.
Contributor
Author
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
==========================================
+ Coverage 76.67% 76.82% +0.15%
==========================================
Files 70 71 +1
Lines 8612 8717 +105
==========================================
+ Hits 6603 6697 +94
- Misses 2009 2020 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
teutoburg
changed the title
teutoburg
added
Science Team
5 tasks
hugobuddel
approved these changes
May 20, 2025
Collaborator
hugobuddel
left a comment
hugobuddel
left a comment
There was a problem hiding this comment.
Looks pretty clean!
I can't see that I fully comprehend everything, but I'm confident that I could if you would win the lottery. In fact, quite some 'bad' code is removed or annotated, so that's nice.
I've added some minor comments; I'll let you decide how to handle those.
github-project-automation
bot
moved this from 👀 Awaiting Review
to ✅ Done
in ScopeSim-development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly adds a
DetectorList3Dclass, which acts as a "virtual 3D detector" as outlined in #550, allowing simplified simulations of (METIS) IFU observations. The output is similar to a rectified and drizzled IFU cube (square pixels), without the computational overhead of those operations. This obviously come at the cost of simulation accuracy, but is considered an acceptable tradeoff for a science team target audience.More effects (like LSF) are needed to simulate those outputs with adequate realism, but this now adds the geometric basis to run those simulations at all. I recommend merging this, and dealing with the rest separately, since it's now at least at a stable working state. "To be added" is also a notebook showcasing this mode, but that should be in the IRDB.
AstarVienna/irdb#233 adds the corresponding mode definitions in the IRDB.