Skip to content

Conversation

@teutoburg
Copy link
Contributor

This was never used anywhere except in testing and is likely a leftover from pre-ScopeSim days.

Came up during #654, but can be treated separately.

This was never used anywhere except in testing and is likely a leftover
from pre-ScopeSim days.
@teutoburg teutoburg self-assigned this May 14, 2025
@teutoburg teutoburg added the refactor Implementation improvement label May 14, 2025
@teutoburg teutoburg moved this from 🆕 New to 👀 Awaiting Review in ScopeSim-development May 14, 2025
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.68%. Comparing base (708a08f) to head (1fc1069).
⚠️ Report is 262 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
- Coverage   76.69%   76.68%   -0.02%     
==========================================
  Files          70       70              
  Lines        8609     8605       -4     
==========================================
- Hits         6603     6599       -4     
  Misses       2006     2006              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teutoburg teutoburg marked this pull request as ready for review May 14, 2025 18:33
@teutoburg teutoburg requested a review from hugobuddel May 14, 2025 18:33
@teutoburg
Copy link
Contributor Author

Increased to urgent because this is blocking #654 to avoid conflicts.

Copy link
Collaborator

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine I think. I suppose this information is still readily available in some other way right?

@teutoburg
Copy link
Contributor Author

I suppose this information is still readily available in some other way right?

Yes, via the detector header footprint (where it was also extracted from for this).

@teutoburg teutoburg merged commit 5089314 into main May 19, 2025
22 checks passed
@teutoburg teutoburg deleted the fh/rmobsolete branch May 19, 2025 10:44
@github-project-automation github-project-automation bot moved this from 👀 Awaiting Review to ✅ Done in ScopeSim-development May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Implementation improvement

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants