Don't include "*_unit" keywords for FITS spectra #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This information is stored in the TUNIT header keywords anyway. Recently, synphot/astropy started complaining when both were supplied to the loader utils function. Reduces warnings seen during test run from 75 to 25.
teutoburg
added
the
bugfix
Contributor
Author
|
No idea why the CI didn't fire here. I ran it manually for the branch, see https://github.com/AstarVienna/speXtra/actions/runs/20129558669 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 76.91% 76.90% -0.01%
==========================================
Files 8 8
Lines 797 801 +4
==========================================
+ Hits 613 616 +3
- Misses 184 185 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This information is stored in the TUNIT header keywords anyway. Recently, synphot/astropy started complaining when both were supplied to the loader utils function.
Reduces warnings seen during test run from 75 to 25.