Skip to content

Don't include "*_unit" keywords for FITS spectra #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teutoburg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't include "*_unit" keywords for FITS spectra #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions spextra/libraries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,30 +45,36 @@ def __init__(self, name):
self._items = yamldict.get(self.aliases["items"], {})
self.spectral_coverage = yamldict.get("spectral_coverage", [])

self.read_kwargs = self._get_read_kwargs(yamldict)
self._validate_units()

self.file_extension = yamldict.get("file_extension", None)
self.read_kwargs = self._get_read_kwargs(yamldict)

def _get_read_kwargs(self, yamldict) -> dict:
read_kwargs = {
"wave_col": yamldict.get(self.aliases["wave_col"], "WAVELENGTH"),
"flux_col": yamldict.get(self.aliases["flux_col"], "FLUX"),
"wave_unit": yamldict.get("wave_unit", "Angstrom"),
"flux_unit": yamldict.get(self.aliases["flux_unit"], "FLAM"),
}

# FITS stores units in TUNIT keywords
if self.data_type != "fits":
read_kwargs.update({
"wave_unit": yamldict.get("wave_unit", "Angstrom"),
"flux_unit": yamldict.get(self.aliases["flux_unit"], "FLAM"),
})
read_kwargs = self._validate_units(read_kwargs)
return read_kwargs

def _validate_units(self) -> None:
@staticmethod
def _validate_units(read_kwargs: dict) -> dict:
for key in ("wave_unit", "flux_unit"):
value = self.read_kwargs[key]
value = read_kwargs[key]
# HACK to understand ext. units
if value == "Av/E(B-V)":
value = "mag"
try:
self.read_kwargs[key] = validate_unit(value)
read_kwargs[key] = validate_unit(value)
except (SynphotError, ValueError) as err:
raise UnitError(f"{value} not understood.") from err
return read_kwargs

@property
def is_in_database(self) -> bool:
Expand Down
Loading