Skip to content

chore: remove unneeded jsx fragments - #1474

Merged
PepperLola merged 2 commits into
devfrom
dionkud/remove-jsx-fragments
Aug 6, 2026
Merged

chore: remove unneeded jsx fragments#1474
PepperLola merged 2 commits into
devfrom
dionkud/remove-jsx-fragments

Conversation

@0xda157

@0xda157 0xda157 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Task

part of SYNTH-224

Symptom

returning null from a component is generally preferred to <></>, and wrapping things unnecessarily in fragments makes them harder to read.

Solution

enabled biome lint

Verification

biome passes

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@0xda157
0xda157 requested review from a team as code owners August 4, 2026 16:05
@0xda157
0xda157 force-pushed the dionkud/remove-jsx-fragments branch from 39554ac to e7caccf Compare August 4, 2026 18:53
PepperLola
PepperLola approved these changes Aug 6, 2026
View reviewed changes

@PepperLola PepperLola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, diff looks good to me

@PepperLola
PepperLola enabled auto-merge (squash) August 6, 2026 00:45
@PepperLola
PepperLola merged commit d9ac34e into dev Aug 6, 2026
19 of 20 checks passed
@PepperLola
PepperLola deleted the dionkud/remove-jsx-fragments branch August 6, 2026 00:47
Dhruv-0-Arora added a commit that referenced this pull request Aug 6, 2026
@Dhruv-0-Arora
fix(lint): drop useless fragment missed by noUselessFragments rollout
abf0963 
PR #1474 enabled complexity/noUselessFragments but did not clean this
one, leaving dev red on `bun run style`.
BrandonPacewic added a commit that referenced this pull request Aug 6, 2026
@BrandonPacewic
chore: merge branch dev
572780e 
* 'dev' of github.com:Autodesk/synthesis: (180 commits)
  Fix Drag Mode During Gizmo Move (#1480)
  chore: remove unneeded jsx fragments (#1474)
  Update Tabs Indicator on Content Size Change (#1428)
  Fix Configuration Input Selection (#1460)
  style: ran formatter
  Improved 2024 Field Collisions
  fix: make cancelling work and make endgame reset
  fix: use start time delay for autonomous
  feat: make match mode timer time-based
  feat: improve match result modal styling
  refactor: use null instead of explicit fallback value for camera selection
  refactor: use string UUIDs instead of incrementing integers
  fix: update array bracket formatting
  chore: refactor out new build parts functionality
  chore: update comments
  feat: obj mesh reduction fix
  feat: glTF dense meshes extra rung
  feat: mesh decimation for obj and gltf
  chore: update comments
  chore: cleanup comments
  ...
BrandonPacewic added a commit that referenced this pull request Aug 6, 2026
@BrandonPacewic
chore: merge branch dev
db822a5 
* 'dev' of github.com:Autodesk/synthesis: (86 commits)
  Fix Drag Mode During Gizmo Move (#1480)
  chore: remove unneeded jsx fragments (#1474)
  Update Tabs Indicator on Content Size Change (#1428)
  Fix Configuration Input Selection (#1460)
  style: ran formatter
  Improved 2024 Field Collisions
  fix: make cancelling work and make endgame reset
  fix: use start time delay for autonomous
  feat: make match mode timer time-based
  feat: improve match result modal styling
  refactor: use null instead of explicit fallback value for camera selection
  refactor: use string UUIDs instead of incrementing integers
  fix: update array bracket formatting
  chore: refactor out new build parts functionality
  chore: update comments
  feat: obj mesh reduction fix
  feat: glTF dense meshes extra rung
  feat: mesh decimation for obj and gltf
  chore: update comments
  chore: cleanup comments
  ...
BrandonPacewic added a commit that referenced this pull request Aug 6, 2026
@BrandonPacewic
chore: merge branch dev
b1b8d4d 
* 'dev' of github.com:Autodesk/synthesis: (180 commits)
  Fix Drag Mode During Gizmo Move (#1480)
  chore: remove unneeded jsx fragments (#1474)
  Update Tabs Indicator on Content Size Change (#1428)
  Fix Configuration Input Selection (#1460)
  style: ran formatter
  Improved 2024 Field Collisions
  fix: make cancelling work and make endgame reset
  fix: use start time delay for autonomous
  feat: make match mode timer time-based
  feat: improve match result modal styling
  refactor: use null instead of explicit fallback value for camera selection
  refactor: use string UUIDs instead of incrementing integers
  fix: update array bracket formatting
  chore: refactor out new build parts functionality
  chore: update comments
  feat: obj mesh reduction fix
  feat: glTF dense meshes extra rung
  feat: mesh decimation for obj and gltf
  chore: update comments
  chore: cleanup comments
  ...
BrandonPacewic added a commit that referenced this pull request Aug 7, 2026
@BrandonPacewic
chore: merge branch dev
d7e76e5 
* 'dev' of github.com:Autodesk/synthesis: (193 commits)
  fix: biome lint and toasts ui
  Fix Drag Mode During Gizmo Move (#1480)
  chore: remove unneeded jsx fragments (#1474)
  Update Tabs Indicator on Content Size Change (#1428)
  Fix Configuration Input Selection (#1460)
  style: ran formatter
  Improved 2024 Field Collisions
  fix: make cancelling work and make endgame reset
  fix: use start time delay for autonomous
  feat: make match mode timer time-based
  feat: improve match result modal styling
  refactor: use null instead of explicit fallback value for camera selection
  refactor: use string UUIDs instead of incrementing integers
  fix: update array bracket formatting
  chore: refactor out new build parts functionality
  chore: update comments
  feat: obj mesh reduction fix
  feat: glTF dense meshes extra rung
  feat: mesh decimation for obj and gltf
  chore: update comments
  ...
BrandonPacewic added a commit that referenced this pull request Aug 7, 2026
@BrandonPacewic
chore: merge branch dev
e56cc35 
* 'dev' of github.com:Autodesk/synthesis: (194 commits)
  fix: biome lint and toasts ui
  Fix Drag Mode During Gizmo Move (#1480)
  chore: remove unneeded jsx fragments (#1474)
  Update Tabs Indicator on Content Size Change (#1428)
  Fix Configuration Input Selection (#1460)
  style: ran formatter
  Improved 2024 Field Collisions
  fix: make cancelling work and make endgame reset
  fix: use start time delay for autonomous
  feat: make match mode timer time-based
  feat: improve match result modal styling
  refactor: use null instead of explicit fallback value for camera selection
  refactor: use string UUIDs instead of incrementing integers
  fix: update array bracket formatting
  chore: refactor out new build parts functionality
  chore: update comments
  feat: obj mesh reduction fix
  feat: glTF dense meshes extra rung
  feat: mesh decimation for obj and gltf
  chore: update comments
  ...
BrandonPacewic added a commit that referenced this pull request Aug 7, 2026
@BrandonPacewic
chore: resolve merge conflicts from branch dev
853085e 
* 'dev' of github.com:Autodesk/synthesis: (227 commits)
  chore: fix ci
  fix: biome lint and toasts ui
  Fix Drag Mode During Gizmo Move (#1480)
  chore: remove unneeded jsx fragments (#1474)
  Update Tabs Indicator on Content Size Change (#1428)
  Fix Configuration Input Selection (#1460)
  refactor: create useHoldPhysicsPause hook
  style: ran formatter
  Improved 2024 Field Collisions
  fix: make cancelling work and make endgame reset
  fix: use start time delay for autonomous
  feat: make match mode timer time-based
  feat: improve match result modal styling
  refactor: use null instead of explicit fallback value for camera selection
  refactor: use string UUIDs instead of incrementing integers
  fix: update array bracket formatting
  chore: refactor out new build parts functionality
  chore: update comments
  feat: obj mesh reduction fix
  feat: glTF dense meshes extra rung
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PepperLola PepperLola PepperLola approved these changes
@rutmanz rutmanz rutmanz approved these changes
@azaleacolburn azaleacolburn Awaiting requested review from azaleacolburn azaleacolburn is a code owner automatically assigned from Autodesk/fission
@Dhruv-0-Arora Dhruv-0-Arora Awaiting requested review from Dhruv-0-Arora Dhruv-0-Arora is a code owner automatically assigned from Autodesk/fission

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xda157 @PepperLola @rutmanz