[Storage] HttpRange replacement, Etag model replacement#42619
[Storage] HttpRange replacement, Etag model replacement#42619vincenttran-msft wants to merge 8 commits intofeature/blob-tsp-rustfrom
HttpRange replacement, Etag model replacement#42619Conversation
Next Steps to MergeImportant checks have failed. As of today they are not blocking this PR, but in near future they may.Addressing the following failures is highly recommended:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
Comment generated by After APIView workflow run. |
| ...IfModifiedSinceParameter, | ||
| ...IfUnmodifiedSinceParameter, | ||
| ...IfNoneMatchParameter, | ||
| ...IfMatchParameter, |
There was a problem hiding this comment.
Are the headers in the Azure.Core.ConditionalRequestHeaders not typed with etag? That's the reason for this update?
There was a problem hiding this comment.
I'll open an issue to get this fixed in the azure.core types
There was a problem hiding this comment.
Changes seem benign to me, I looked through client.tsp and the languages seem to be changing the conditional header types back to string from etag anyways for other instances. cc @l0lawrence @jeremymeng @gracewilcox @jorgerangel-msft
catalinaperalta
left a comment
There was a problem hiding this comment.
@vincenttran-msft please fix the typespec validation error before merging into the base branch
No description provided.