Skip to content

[Storage] HttpRange replacement, Etag model replacement#42619

Open
vincenttran-msft wants to merge 8 commits intofeature/blob-tsp-rustfrom
vincenttran/fix_ranges
Open

[Storage] HttpRange replacement, Etag model replacement#42619
vincenttran-msft wants to merge 8 commits intofeature/blob-tsp-rustfrom
vincenttran/fix_ranges

Conversation

@vincenttran-msft
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

Next Steps to Merge

Important checks have failed. As of today they are not blocking this PR, but in near future they may.
Addressing the following failures is highly recommended:
  • ⚠️ The check named SDK Validation Status has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide
If you still want to proceed merging this PR without addressing the above failures, refer to step 4 in the PR workflow diagram.

Comment generated by summarize-checks workflow run.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Storage.Blob
Python azure-storage-blob

Comment generated by After APIView workflow run.

@jalauzon-msft jalauzon-msft marked this pull request as ready for review April 24, 2026 20:20
Comment on lines +704 to +707
...IfModifiedSinceParameter,
...IfUnmodifiedSinceParameter,
...IfNoneMatchParameter,
...IfMatchParameter,
Copy link
Copy Markdown
Member

@catalinaperalta catalinaperalta Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the headers in the Azure.Core.ConditionalRequestHeaders not typed with etag? That's the reason for this update?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open an issue to get this fixed in the azure.core types

Copy link
Copy Markdown
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem benign to me, I looked through client.tsp and the languages seem to be changing the conditional header types back to string from etag anyways for other instances. cc @l0lawrence @jeremymeng @gracewilcox @jorgerangel-msft

Copy link
Copy Markdown
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincenttran-msft please fix the typespec validation error before merging into the base branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files) TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants