chore(web/app): remediate Dependabot vulns#10131
Conversation
Git-on-my-level
left a comment
There was a problem hiding this comment.
Thanks for tackling the web/app dependency vulnerabilities.
I’m requesting changes because the current head still does not audit cleanly. I checked the PR branch with a secrets-stripped environment using:
env -i PATH="$PATH" HOME=/tmp/omi-pr10131-home npm audit --package-lock-only --json
That still reports 1 high-severity vulnerability:
brace-expansion(GHSA-3jxr-9vmj-r5cp) via bothnode_modules/brace-expansionandnode_modules/@typescript-eslint/typescript-estree/node_modules/brace-expansion; npm reports this is fixable withnpm audit fix.
Since the PR description says “Post-fix audit: 0 vulnerabilities,” please rerun npm audit fix / update the lockfile so web/app actually returns 0 vulnerabilities on the PR head. The package changes otherwise look narrowly scoped to npm registry dependency bumps/overrides, and I did not see suspicious registry URLs or script changes in the diff, but this should not merge until the remaining audit finding is resolved and CI is green.
by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with need human response.
cdc5147 to
ab4b175
Compare
Follow-up completedRebased onto current
The application build requires Firebase public environment variables, so fresh GitHub CI is the authoritative build validation and is now running. |
ab4b175 to
d7f0848
Compare
Git-on-my-level
left a comment
There was a problem hiding this comment.
Approved after the stale review finding was repaired, the branch was rebased, local preflight passed, independent gpt-5.6-terra review approved the exact rebased head, and fresh CI passed with a clean full dependency audit.
Failure-Class: none
npm audit fixresolved all transitive vulnerabilities inweb/app