Skip to content

chore(web/app): remediate Dependabot vulns#10131

Merged
Git-on-my-level merged 2 commits into
mainfrom
fix/web-app-deps-bump
Jul 21, 2026
Merged

chore(web/app): remediate Dependabot vulns#10131
Git-on-my-level merged 2 commits into
mainfrom
fix/web-app-deps-bump

Conversation

@undivisible

@undivisible undivisible commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Failure-Class: none

  • npm audit fix resolved all transitive vulnerabilities in web/app
  • Added override floor pins: @grpc/grpc-js >=1.9.16, protobufjs >=7.6.3, @babel/core >=7.26.0, js-yaml >=4.1.1, websocket-driver >=0.5.8
  • Post-fix audit: 0 vulnerabilities

Review in cubic

@Git-on-my-level Git-on-my-level added dependency-review Touches dependencies or lockfiles; needs dependency review needs-maintainer-review Needs a human maintainer to sign off before merge labels Jul 20, 2026

@Git-on-my-level Git-on-my-level left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling the web/app dependency vulnerabilities.

I’m requesting changes because the current head still does not audit cleanly. I checked the PR branch with a secrets-stripped environment using:

env -i PATH="$PATH" HOME=/tmp/omi-pr10131-home npm audit --package-lock-only --json

That still reports 1 high-severity vulnerability:

  • brace-expansion (GHSA-3jxr-9vmj-r5cp) via both node_modules/brace-expansion and node_modules/@typescript-eslint/typescript-estree/node_modules/brace-expansion; npm reports this is fixable with npm audit fix.

Since the PR description says “Post-fix audit: 0 vulnerabilities,” please rerun npm audit fix / update the lockfile so web/app actually returns 0 vulnerabilities on the PR head. The package changes otherwise look narrowly scoped to npm registry dependency bumps/overrides, and I did not see suspicious registry URLs or script changes in the diff, but this should not merge until the remaining audit finding is resolved and CI is green.


by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with need human response.

@Git-on-my-level
Git-on-my-level force-pushed the fix/web-app-deps-bump branch from cdc5147 to ab4b175 Compare July 21, 2026 03:18
@Git-on-my-level

Copy link
Copy Markdown
Collaborator

Follow-up completed

Rebased onto current main and updated the lockfile to resolve the remaining brace-expansion advisory. Local verification on the pushed head:

  • npm ci --ignore-scripts --no-audit --no-fund
  • npm audit --package-lock-only --json → 0 findings ✅
  • make preflight

The application build requires Firebase public environment variables, so fresh GitHub CI is the authoritative build validation and is now running.

@Git-on-my-level
Git-on-my-level force-pushed the fix/web-app-deps-bump branch from ab4b175 to d7f0848 Compare July 21, 2026 03:25

@Git-on-my-level Git-on-my-level left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after the stale review finding was repaired, the branch was rebased, local preflight passed, independent gpt-5.6-terra review approved the exact rebased head, and fresh CI passed with a clean full dependency audit.

@Git-on-my-level
Git-on-my-level merged commit d4687fb into main Jul 21, 2026
29 checks passed
@Git-on-my-level
Git-on-my-level deleted the fix/web-app-deps-bump branch July 21, 2026 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency-review Touches dependencies or lockfiles; needs dependency review needs-maintainer-review Needs a human maintainer to sign off before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants