Skip to content

Conversation

@lola831
Copy link
Collaborator

@lola831 lola831 commented Nov 25, 2025

Description

MetaDrive needs to download an assets folder from a remote URL the first time it runs. On a local machine this usually happens once per virtual environment and is then cached. In CI, each run starts from a clean environment, so MetaDrive has to download the assets every time, and if that download fails, all of our MetaDrive tests fail.

This PR updates test_metadrive.py so that we explicitly call metadrive.pull_asset(update=False) before running any tests. If the asset download fails, we skip the entire MetaDrive test file instead of failing CI.

This keeps the MetaDrive tests from failing due to temporary download issues while still running them whenever the assets can be fetched successfully.

Issue Link

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@lola831 lola831 requested a review from dfremont November 25, 2025 20:21
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.91%. Comparing base (e093379) to head (b032170).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   89.86%   89.91%   +0.04%     
==========================================
  Files          54       54              
  Lines       13549    13556       +7     
==========================================
+ Hits        12176    12189      +13     
+ Misses       1373     1367       -6     

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Lola!

@dfremont dfremont merged commit 3a07fa0 into BerkeleyLearnVerify:main Nov 26, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants