Skip to content

Interactions view #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: staging
Choose a base branch
from
Open

Interactions view #153

wants to merge 23 commits into from

Conversation

y330
Copy link
Contributor

@y330 y330 commented Feb 25, 2025

Interactions View

The final changes I made:

  • changed apply filter button on filter dialog to the eplant green color
  • changed info icon on snackbar (which alerts the user about the sublocalization issue) to eplant green color
  • removed noInteractionsNode (it was just showing up as a blank gray circle)
  • added jsdoc to all functions
  • added organizational comments to the jsx

Notes

  • There is still the issue where sublocalization colors (the colors around the nodes) dont always show up automatically, happens about 20% of the time. I tried many possible solutions but nothing seems to fix the issue
  • The load gene button on gene tooltip does not work, which I believe is because jotai state might only be accesible from react components, and not from the a .ts file with regular functions that the cytoscape load gene tooltip is created from

Preview of view

image
image
image
image
image

y330 and others added 21 commits August 8, 2024 11:32
…n its impossible with jotais capabilties (see comment on eventHandler.ts), 2. Added some filter mechanism for the edges and nodes
…required for filtering genes in interactions view
…ks to the tippy logic for the tooltips on edges, now they follow the cursor
…tionaility albeit longer file. FIxed typing for everything, TODO: add delay and fade to popups, add loading screen in between changing genes, fix button to load gene
… button and info icon to eplant green, removed unneccesary grey noInteractionsNode, changed tippyFactory to tooltipCreator. NOTES: Ran lint:fix. ready to create pr
in the last commit to fix the gray circle not aligning with the query node,
when there was no interactions.
 turns out the fix was removing the NoInteractionsNode
@y330 y330 added the Interactions Viewer view Any issue pertaining to the Interactions Viewer view label Feb 25, 2025
@y330 y330 requested review from VinLau, mwkyuen and Yukthiw February 25, 2025 17:55
@VinLau
Copy link
Collaborator

VinLau commented Mar 20, 2025

@y330
Some overall feedback:

  • Merge with staging to keep up to date
  • Include strand data (- or +) for each tooltip
  • Graph looks pretty good but sometimes the search gene is overlapping another gene. I think in Cytoscape there is a repulsion factor
image
  • For PDI square nodes increase font/legibility of interactors
  • Load gene is broken but it won't matter due to routing PR
  • Typo on filter "Protien-DNA"
  • Overall well done for first attempt, should be easy to fix above
  • I have some lingering questions on your cytoscape design and whether you copied it straight from ePlant2 such as using "event.target._private.classes" when we can call classes using a cytoscape function. But we can discuss that in a call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interactions Viewer view Any issue pertaining to the Interactions Viewer view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants