Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix computing Transformation based on pairwise alignment #63

Merged

Conversation

andreasKroepelin
Copy link
Contributor

Thanks for maintaining this package, saves me a lot of work!

I have found a subtle bug in the function that computes a Transformation based on a pairwise alignment. In it, we want to collect all atoms belonging to residues that were (mis)matched in the alignment. To ensure that the number of atoms that are later used for the Kabsch algorithm are equal, we have to check for every residue if their atom counts match, even if the residues produced a mismatch in the alignment. However, the previous code only checked if the so-far collected atoms have the same amount (the invariant we want to maintain) where it should check if the atoms about to be added have the same amount.

I adapted the code and added a short explanatory comment. Let me know if anything else should be added!

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base (7e0f427) to head (12dcf29).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files          14       14           
  Lines        1916     1916           
=======================================
  Hits         1820     1820           
  Misses         96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgreener64 jgreener64 merged commit 79e5faa into BioJulia:master Mar 13, 2025
9 checks passed
@jgreener64
Copy link
Member

Thanks for finding this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants