feat(sdk-coin-near): added fungible token transfer builder #6203
Conversation
ravibitgo
force-pushed
the
COIN-4148
branch
2 times, most recently
from
58a8aa3 to
6270567
Compare
| public get deposit(): string { | ||
| return this._deposit; | ||
| } | ||
|
|
||
| /** Get args, which are the parameters of a method */ | ||
| public set args(args: Record<string, unknown>) { | ||
| this._args = args; | ||
| this._args = { ...this._args, ...args }; |
There was a problem hiding this comment.
why is this change required?
There was a problem hiding this comment.
In the current implementation we were only dealing with a single field inside this _args so directly setting it was working. Now for ft we have to set multiple fields (receiver_id, amount, memo), so modified this to accept each field so I can add setters for each field.
| @@ -166,16 +232,20 @@ export class Transaction extends BaseTransaction { | |||
| case StakingContractMethodNames.Withdraw: | |||
| this.setTransactionType(TransactionType.StakingWithdraw); | |||
| break; | |||
| case FT_TRANSFER: | |||
| this.setTransactionType(TransactionType.SendToken); | |||
There was a problem hiding this comment.
I think this should be TransactionType.Send
There was a problem hiding this comment.
Also this should not be inside setTypeByStakingMethod method
| @@ -29,6 +30,8 @@ export class TransactionBuilderFactory extends BaseTransactionBuilderFactory { | |||
| return this.getStakingDeactivateBuilder(tx); | |||
| case TransactionType.StakingWithdraw: | |||
| return this.getStakingWithdrawBuilder(tx); | |||
| case TransactionType.SendToken: | |||
There was a problem hiding this comment.
This should be part of TransactionType.Send
| * | ||
| * @param accountId the contract address | ||
| */ | ||
| public receiverId(accountId: string): this { |
There was a problem hiding this comment.
I think let's use receiverId for the receiver of fungible tokens. And in order to set contract address, we can probably have another setter
There was a problem hiding this comment.
If you check the abstractTransaction.ts of near in bgms, we are initializing the builder like this,
this.transactionBuilder .sender() .nonce() .receiverId() .recentBlockHash();
so either we will have to modify in sdk or modify all the builders in bgms.
modules/sdk-coin-near/test/unit/transactionBuilder/fungibleTokenTransferBuilder.ts
Outdated
Show resolved
Hide resolved
modules/sdk-coin-near/test/unit/transactionBuilder/fungibleTokenTransferBuilder.ts
Outdated
Show resolved
Hide resolved
| should.equal(factoryProd.getFungibleTokenTransferBuilder().coinName(), coinName); | ||
| // used type any to access protected properties | ||
| const txBuilder: any = factory.getFungibleTokenTransferBuilder(); | ||
| const txBuilderProd: any = factoryProd.getFungibleTokenTransferBuilder(); |
There was a problem hiding this comment.
can you please try to avoid any
There was a problem hiding this comment.
since we need to access the protected properties, need to use any here
ravibitgo
force-pushed
the
COIN-4148
branch
2 times, most recently
from
19ffc0b to
7b39cdc
Compare
PR Summary
This PR introduces the
FungibleTokenTransferBuilderclass, responsible for constructing fungible token transfer transactions on NEAR.In addition to this new feature, a major upgrade has been made to the
near-api-jspackage, moving from version0.x.xto5.x.x.New Feature:
FungibleTokenTransferBuilderto handle fungible token transaction creation.Dependency Upgrade:
near-api-jsfrom 0.x.x to 5.x.x.Required Legacy Code Changes Due to API Upgrade:
All amount values (e.g., deposit, gas) have been updated from BN to native BigInt.
Transaction signatures now support multiple key types. Direct access to signature data like
this._nearSignedTransaction.signature.datais no longer valid; logic has been updated accordingly.Public keys are now returned in raw format. Instead of t
his._nearTransaction.publicKey.toString(), we now derive a human-readable public key usingthis._nearSignedTransaction.signature.ed25519Signature.dataviaUint8Array.The
nearAPI.transactions.SCHEMAstructure has changed. NEAR has introduced multiple schemas, requiring updates to serialization/deserialization logic.After deserializing a raw transaction, Action objects must now be constructed manually. They are no longer directly accessible from the deserialized transaction.
Ticket: COIN-4148