Increase code sanity and test coverage #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
commented
Oct 24, 2025
| */ | ||
|
|
||
| outbuf_size = (*buf_size); | ||
| outbuf_size = nbytes; |
There was a problem hiding this comment.
In the event that for whatever reason libhdf5 passed us a buffer that is larger than the data, this saves us some bytes.
crusaderky
commented
Oct 24, 2025
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.5.0) | |||
| cmake_minimum_required(VERSION 3.10.0) | |||
There was a problem hiding this comment.
Suppresses a deprecation warning
crusaderky
force-pushed
the
sanity_and_tests
branch
from
8100b18 to
29416b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from #38.
blosc_filter.c. There are no functional changes.