Add parallel I/O output system#713
Open
SeanBryan51 wants to merge 8 commits intomainfrom
Open
Conversation
4c009fd to
b226a95
Compare
beefeab to
0d53f58
Compare
Co-authored-by: Lachlan Whyborn <[email protected]>
This is done to allow access to private components of derived types in child submodules. See this bug report for more details: https://community.intel.com/t5/Intel-Fortran-Compiler/Intel-oneAPI-bug-with-submodules/td-p/1347530
0d53f58 to
cfb572c
Compare
cfb572c to
458d67d
Compare
458d67d to
df516f5
Compare
Collaborator
Author
|
Hi @abhaasgoyal @Whyborn, thank you for your time in reviewing these PRs! This one is now ready for review, and no rush of course, it's the heaviest one so far! As an introduction, it might be useful to read these developer documentation pages:
Benchcab is running currently - I had to make a small change to achieve bitwise compatibility, I will update the status soon. Thank you again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change brings in a new output system based on the parallel I/O infrastructure introduced in #706, and is a direct replacement of the previous output module used for offline CABLE. The main motivation behind this is to add MPI support to the serial offline driver, and eventually, to replace the legacy MPI implementation (#358). This also makes progress towards the proposed output redesign (#715) by introducing the underlying data structures needed for its implementation.
The new output system brings in the following enhancements:
This change should be brought in after #712.
Type of change
Please delete options that are not relevant.
Checklist
Testing
CABLE benchcab runs tested using
ifort2021.10.0.Please add a reviewer when ready for review.
📚 Documentation preview 📚: https://cable--713.org.readthedocs.build/en/713/