Skip to content

Sync-Fix #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 50 commits into from
Closed

Sync-Fix #44

wants to merge 50 commits into from

Conversation

carykees98
Copy link
Collaborator

Syncs are failing with code 10 or 30 more than they should be.

This PR aims to fix that problem as well as a few others:

  • Rsync password files were being read from the wrong place
  • Currently Rsync stdout and stderr are being discarded, at a minimum stderr should be written to a file if it contains anything to make identifying issues possible

carykees98 added 30 commits April 7, 2025 18:33
@carykees98
change location of secrets files
002f90e
@carykees98
add secrets directory to gitignore
27b57ec
@carykees98
fixed typo in JobManager
57a4b92
@carykees98
updating SyncDetails to work with new mirrors.json schema
5177906
@carykees98
updated format for SyncScheduer.cpp
ca303ea
@carykees98
updated JobManager to work with mirrors.json change
a0601c4
@carykees98
trying to figure out what is causing an error
bed3549
@carykees98
more debug
26f1bc3
@carykees98
debug again
9c9b699
@carykees98
maybe the fix?
b373b8f
@carykees98
more debug (wooo)
3989f30
@carykees98
moved command logging
784e5f6
@carykees98
debug and formatting update
5d6ce6b
@carykees98
libfmt cant format json, using dump instead
e15aa75
@carykees98
adding host, source, and dest shouldn't have been a nested loop
48de63f
@carykees98
debug print to see if fix worked
e7425fe
@carykees98
log stderr for failing rsync processes
20a49bb
@carykees98
close stdout and stderr pipes before removing job from active jobs map
981b588
@carykees98
removed extra qualification from write_stderr_to_file
635c809
@carykees98
write stdout and stderr instead of just stderr
7e9fbf3
@carykees98
don't use ioctl, just read into a buffer of size bufsiz
d47be4e
@carykees98
had been registering closed write end of pipe as read end
98dc3fd
@carykees98
last item in argv has to be nullptr
24fe5d4
@carykees98
updated warning for failed sync
c6a59cc
@carykees98
resize stream contents string after clearing it
fe9ae41
@carykees98
update compose files
7068c5f
@carykees98
fixed bug where all syncs would be interrupted if one timed out
308b28d
@carykees98
added zsh to sync scheduler docker file to run fedora sync
0d0d9ea
@carykees98
updated how stderr and stdout are written to files
464e2f3
@carykees98
added ability to manual sync all projects
0fa2877
carykees98 and others added 20 commits April 25, 2025 04:00
@carykees98
passed the wrong variable to start_sync when syncing all projects
2a52db2
@carykees98
fixed script commands not being properly composed
048af47
@carykees98
tty true for colored logs
9bfa664
@carykees98
log project name instead of "all_projects" when failing to start a ma…
52c3d87 
…nual all project sync
@carykees98
updated formatting for script command string
d7a847d
@carykees98
treat argument as string instead of auto
33604fa
@carykees98
more formatting
e53ba35
@carykees98
back to what it was?
a11d3f6
@carykees98
add shebang to kicad sync script
83383bc
@carykees98
Update docker-compose-prod.yaml
2194572
@carykees98
Update SyncScheduler.cpp
967b1ce
@carykees98
😑
859e3d4
@carykees98
default argument defined in the wrong place
bb15aff
@carykees98
updated format string
c80b8a9
@carykees98
added debug messages
0be5f66
@carykees98
more debug
bcb6fde
@carykees98
static
707a259
@carykees98
dont reap processes in interrupt_process as they will likely be reape…
6f70dae 
…d by their own parent
@carykees98
added todo
285ab63
@carykees98
Increased sync time limit from 1 hour to 3
8d039e5
@carykees98 carykees98 marked this pull request as ready for review July 9, 2025 01:45
brendanjconnelly
brendanjconnelly approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@brendanjconnelly brendanjconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brendanjconnelly brendanjconnelly mentioned this pull request Aug 28, 2025
Open
@brendanjconnelly
Copy link
Contributor

brendanjconnelly commented Aug 28, 2025 •
edited
Loading

I created a new branch for testing this on elephant (and had to make a few changes), so I am going to close this pull request and this merge will continue in #48.

I could have just rebased this on main, but I Really Didn't Feel Like It.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendanjconnelly brendanjconnelly brendanjconnelly approved these changes

@aHalliday13 aHalliday13 Awaiting requested review from aHalliday13

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carykees98 @brendanjconnelly