-
Notifications
You must be signed in to change notification settings - Fork 0
Sync scheduler fixes #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…nual all project sync
…d by their own parent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a couple comments, but nothing stands out to me as being majorly flawed. Has this been tested on Erised or Elephant? If so I'd be fine with approving this and deploying.
return completedJobs; | ||
} | ||
|
||
auto JobManager::write_streams_to_file(const ::pid_t processID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a random number is being assigned to the log files? maybe it might make more sense to use a timestamp when the log file is generated?
Continuation of #44
Changes from previous PR in sync scheduler:
Add more logging (helps identify problematic entries in mirrors.json)
Add more general exception handling (scheduler will fail gracefully and skip invalid projects)
Update the development config for mirrors.json to reflect new schema for scripts