Skip to content

Conversation

brendanjconnelly
Copy link
Contributor

@brendanjconnelly brendanjconnelly commented Aug 28, 2025

Continuation of #44

Changes from previous PR in sync scheduler:
Add more logging (helps identify problematic entries in mirrors.json)
Add more general exception handling (scheduler will fail gracefully and skip invalid projects)
Update the development config for mirrors.json to reflect new schema for scripts

@brendanjconnelly brendanjconnelly mentioned this pull request Aug 28, 2025
Copy link
Member

@aHalliday13 aHalliday13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a couple comments, but nothing stands out to me as being majorly flawed. Has this been tested on Erised or Elephant? If so I'd be fine with approving this and deploying.

return completedJobs;
}

auto JobManager::write_streams_to_file(const ::pid_t processID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a random number is being assigned to the log files? maybe it might make more sense to use a timestamp when the log file is generated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants