Skip to content

init project6a kavita#1728

Closed
kavita57 wants to merge 6 commits intoChameleon-company:masterfrom
kavita57:master
Closed

init project6a kavita#1728
kavita57 wants to merge 6 commits intoChameleon-company:masterfrom
kavita57:master

Conversation

@kavita57
Copy link
Copy Markdown
Collaborator

@kavita57 kavita57 commented Apr 3, 2026

Summary
This PR captures the notebook-based crack-detection work in Playground/project_6a. The project now documents two workflows: a crack segmentation benchmark that falls back to binary classification when masks are unavailable, and a YOLO11-based cracked-vs-uncracked classification pipeline built on SDNET2018.

What changed

  • Adds the crack segmentation benchmark notebook with automatic dataset detection.
  • Falls back to binary crack classification when segmentation masks are not present.
  • Benchmarks classification models including resnet18 and efficientnet_b0.
  • Adds the YOLO11 still-image classification notebook for SDNET2018.
  • Records dataset splits, training outputs, checkpoints, plots, and metrics under artifacts/ and runs/.
  • Documents the path mismatch between the recorded YOLO run and the notebook's evaluation path.

User impact
This gives the team a reproducible training and evaluation workflow for crack detection on SDNET2018. It also preserves the benchmark outputs so results can be reviewed, compared, and rerun with the same project structure.

Testing

  • Confirmed the notebooks detect the available dataset layout.
  • Verified the classification fallback runs when segmentation masks are missing.
  • Confirmed benchmark artifacts are written for model checkpoints, metrics, and plots.
  • Noted the YOLO evaluation cells need the trained weights path pointed at the saved best.pt file.

@kavita57 kavita57 marked this pull request as draft April 3, 2026 05:01
@kavita57 kavita57 marked this pull request as ready for review April 3, 2026 05:01
@IshikaAnand7 IshikaAnand7 self-requested a review April 3, 2026 05:02
Copy link
Copy Markdown
Collaborator

@IshikaAnand7 IshikaAnand7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@kavita57 kavita57 requested a review from IshikaAnand7 April 3, 2026 05:22
@kavita57 kavita57 requested a review from manya0033 April 3, 2026 05:41
Copy link
Copy Markdown
Collaborator

@manya0033 manya0033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Kavita, I've gone through both notebooks and the PR. The work itself is really solid -both notebooks are well-structured with clear markdown explanations at each step, the code is clean, and the segmentation-to-classification fallback logic is a nice design choice. A few things need fixing before I can approve though, based on the PR checklist:

  1. PR title format - The title needs to include your team's name, the project name matching your Trello card, and the completion percentage.

  2. PR source - This is coming from kavita57: master (your personal fork) rather than a branch on the company repo. PRs should come from a dedicated branch after cloning the Chameleon-company repository (e.g. Chameleon-company:kavita_crack_detection). Could you redo this from a branch on the company repo?

  3. Australian English - The first notebook (01_crack_segmentation_benchmark) has a few American English spellings that need updating: visualization - visualisation, optimize - optimise. The second notebook is fine.

  4. Dataset access - Both notebooks load data from local directories (./dataset, ./data/crack_segmentation). The checklist requires datasets to be accessed via API v2.1.

  5. Model weight files - yolo11n-cls.pt and yolo26n.pt are committed to the repo. Binary model weights are large files that bloat the repository. These should be excluded (add them to .gitignore) and either downloaded at runtime or documented so others know where to get them.

  6. Reviewer turnaround - I noticed the review was self-requested and approved within 29 minutes of the PR being opened. With 6,904 lines across two ML notebooks, it might be worth having the second reviewer do a more thorough pass to catch things like the points above.

The notebooks themselves are genuinely well-built, Once the checklist items are addressed this should be good to go. Tag me when you push the updates.

@kavita57 kavita57 closed this Apr 15, 2026
@kavita57
Copy link
Copy Markdown
Collaborator Author

opened the the thread on #1783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants