Change liebert fans check metrics to "fan_perc" #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your interest in contributing to Checkmk!
Consider looking into Readme regarding process details.
General information
Various liebert CRAC units with fans currently report fan status in "file handles." This is somewhat nonsensical. This pull request corrects these checks to use the "fan_perc" metric, in line with other checks that use fans.
Proposed changes
This may cause issues with existing graphs, which are still in file_handles. At least on my system, the old graph remains with historical data, while a new graph with the expected "Fan Speed" metric also appears with new data.
I'm not sure of a simple way to fix this (or if it needs to be fixed), but I saw no mention of the issues from others, so I feel a decision should be made one way or the other.
Thank you for your consideration!