Skip to content

Change liebert fans check metrics to "fan_perc" #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Change liebert fans check metrics to "fan_perc" #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a4aafb
Change liebert fans check metric to "fan_perc".
indigoparadox Jan 27, 2025
526fef3
Fixed liebert fans unit tests to also use fan_perc.
indigoparadox Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmk/plugins/liebert/agent_based/liebert_fans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def check_liebert_fans(

yield from check_levels_v1(
value,
metric_name="filehandler_perc",
metric_name="fan_perc",
levels_lower=params.get("levels_lower"),
levels_upper=params["levels"],
render_func=lambda x: f"{x:.2f} {unit}",
Expand Down
2 changes: 1 addition & 1 deletion cmk/plugins/liebert/agent_based/liebert_fans_condenser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def check_liebert_fans_condenser(
return
yield from check_levels_v1(
value,
metric_name="filehandler_perc",
metric_name="fan_perc",
levels_lower=params.get("levels_lower"),
levels_upper=params["levels"],
render_func=lambda x: f"{x:.2f} {unit}",
Expand Down
2 changes: 1 addition & 1 deletion cmk/plugins/liebert/agent_based/liebert_reheating.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def check_liebert_reheating(params: Mapping[str, Any], section: Section[float])
value, unit = data
yield from check_levels_v1(
value,
metric_name="filehandler_perc",
metric_name="fan_perc",
levels_upper=params["levels"],
render_func=lambda x: f"{x:.2f} {unit}",
)
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/cmk/plugins/liebert/agent_based/test_liebert_fans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ def test_check() -> None:
state=State.WARN,
summary="1.30 % (warn/crit below 2.00 %/1.00 %)",
),
Metric("filehandler_perc", 1.3, levels=(80, 90)),
Metric("fan_perc", 1.3, levels=(80, 90)),
]
2 changes: 1 addition & 1 deletion tests/unit/cmk/plugins/liebert/agent_based/test_liebert_fans_condenser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,5 @@ def test_check() -> None:
state=State.CRIT,
summary="4.20 out of 10 clowns (warn/crit below 8.00 out of 10 clowns/9.00 out of 10 clowns)",
),
Metric("filehandler_perc", 4.2, levels=(80, 90)),
Metric("fan_perc", 4.2, levels=(80, 90)),
]