fix: disable callback tracing in Streamlit UI runs by default#72
Closed
DavidJBianco wants to merge 1 commit into
Closed
fix: disable callback tracing in Streamlit UI runs by default#72DavidJBianco wants to merge 1 commit into
DavidJBianco wants to merge 1 commit into
Conversation
3 tasks
Collaborator
Author
|
Superseded by #87. The fix was applied as a default change in peak_assistant_chat() (debug_agents: bool = True → False) rather than hardcoding False at call sites, since the main branch had already threaded the parameter through. Merged into dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
msgs.txt/results.txt), which creates an information exposure and disk-growth risk.Description
debug_agents=Falseinstead ofTrueinpeak_assistant/streamlit/util/ui.py, preventing default injection ofpreprocess_messages_logging/postprocess_messages_loggingcallbacks while preserving agent behavior.Testing
pytestand it failed during collection due to a missing dependency (ModuleNotFoundError: No module named 'dotenv'), so no tests specific to this change could be executed in this environment.Codex Task