Skip to content

fix: disable callback tracing in Streamlit UI runs by default#72

Closed
DavidJBianco wants to merge 1 commit into
mainfrom
codex/propose-fix-for-logging-vulnerability
Closed

fix: disable callback tracing in Streamlit UI runs by default#72
DavidJBianco wants to merge 1 commit into
mainfrom
codex/propose-fix-for-logging-vulnerability

Conversation

@DavidJBianco

Copy link
Copy Markdown
Collaborator

Motivation

  • Prevent routine Streamlit UI interactions from enabling agent callback file logging that persists prompt/response content to disk (msgs.txt / results.txt), which creates an information exposure and disk-growth risk.

Description

  • Updated the Streamlit UI runner calls to invoke the agent runner with debug_agents=False instead of True in peak_assistant/streamlit/util/ui.py, preventing default injection of preprocess_messages_logging/postprocess_messages_logging callbacks while preserving agent behavior.

Testing

  • Ran unit test collection with pytest and it failed during collection due to a missing dependency (ModuleNotFoundError: No module named 'dotenv'), so no tests specific to this change could be executed in this environment.

Codex Task

@DavidJBianco

Copy link
Copy Markdown
Collaborator Author

Superseded by #87. The fix was applied as a default change in peak_assistant_chat() (debug_agents: bool = True → False) rather than hardcoding False at call sites, since the main branch had already threaded the parameter through. Merged into dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant