fix: make agent debug callback logging opt-in everywhere#87
Closed
DavidJBianco wants to merge 2 commits into
Closed
fix: make agent debug callback logging opt-in everywhere#87DavidJBianco wants to merge 2 commits into
DavidJBianco wants to merge 2 commits into
Conversation
Changes the debug_agents default from True to False in peak_assistant_chat() so prompt/response content is not written to msgs.txt/results.txt on every Streamlit interaction. No callers pass debug_agents explicitly, so the default change covers all UI paths. Supersedes PR #72. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Merged into dev via fast-forward (batch-d-refiner-fixes chain). |
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops
msgs.txt/results.txtbeing written on every agent run by making thepreprocess/postprocess_messages_loggingcallbacks opt-in rather than the default.Two changes, no file overlap between them:
Streamlit UI (
peak_assistant/streamlit/util/ui.py):debug_agentsdefault fromTrue→Falseinpeak_assistant_chat(). No callers pass the argument explicitly, so the default change covers all UI paths. This is a cleaner fix than hardcodingFalseat each call site as PR fix: disable callback tracing in Streamlit UI runs by default #72 proposed — themainbranch had already threadeddebug_agentsas a parameter, but left the default wrong.CLIs (
data_assistant/__main__.py,planning_assistant/__main__.py,hypothesis_assistant/hypothesis_refiner_cli.py):--debug-agentsflag to each CLI. Callbacks are only wired when the flag is passed. Supersedes PR fix: make agent callback logging opt-in for CLIs #73 (cherry-picked directly).Closes #72 and #73 (superseded).
Test plan
--debug-agentsand confirm nomsgs.txt/results.txtare created--debug-agentsand confirm the files are created as before🤖 Generated with Claude Code