Skip to content

Conversation

@Light-Wave
Copy link
Contributor

Summary

Bugfixes "[Sorcerer] Makes Sorcerer only boost Magiclysm and Sorcerer spells, add latest spells from Magiclysm"

Purpose of change

Make it so that Sorcerer doesn't buff spells from mods like MoM. To do that, spellcasting_adjustment('caster_level') is needed. But it turned out that that was broken, so I fixed that too.
While I was at it, I also added two spells to Sorcerer that were created in #83088.
Fixes #83283.

Describe the solution

Don't throw away preexisting temp_level_adjustment in evaluate_opens_spellbook_data().
Change Sorcerer to use u_spellcasting_adjustment('caster_level', 'mod': 'magiclysm') and u_spellcasting_adjustment('caster_level', 'mod': 'sorcerer')
Added the new spells by running generate_code.py. Found and fixed minor error in generate_code.py.
Changed Bloodrager code to only set the spell level adjustment once per mod.

Describe alternatives you've considered

Break this up into two or three pull requests? Not sure what is best practice here.

Testing

Made a Sorcerer with MoM spells before any changes, noticed Sorcerer spell bonuses were applied to all spells.
Made the .json changes, noticed Sorcerer spell bonuses were not applied to any spells at all.
Made C++ changes and compiled, noticed Sorcerer spell bonuses were applied only to the Magiclysm and Sorcerer spells as intended.

Additional context

@Standing-Storm might be happy to know that spellcasting_adjustment('caster_level') is now working correctly.

…s, add newly added spells, make bloodrager code a tiny bit better
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` [Python] Code made in Python Mechanics: Enchantments / Spells Enchantments and spells labels Oct 15, 2025
@github-actions github-actions bot requested a review from KorGgenT October 15, 2025 13:25
@github-actions github-actions bot added the <Bugfix> This is a fix for a bug (or closes open issue) label Oct 15, 2025
@Light-Wave Light-Wave changed the title fix spellcasting_adjustment('caster_level'), [Sorcerer] Makes Sorcerer only boost Magiclysm and Sorcerer spells, add 2 new spells fix spellcasting_adjustment('caster_level'), [Sorcerer] Makes Sorcerer only boost Magiclysm and Sorcerer spells, add 2 more spells from Magiclysm Oct 15, 2025
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 15, 2025
@Maleclypse Maleclypse merged commit 4cd3f9c into CleverRaven:master Oct 17, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells [Python] Code made in Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sorcerer spell level adjustment affects all supernatural abilities

2 participants