fix spellcasting_adjustment('caster_level'), [Sorcerer] Makes Sorcerer only boost Magiclysm and Sorcerer spells, add 2 more spells from Magiclysm #83316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "[Sorcerer] Makes Sorcerer only boost Magiclysm and Sorcerer spells, add latest spells from Magiclysm"
Purpose of change
Make it so that Sorcerer doesn't buff spells from mods like MoM. To do that,
spellcasting_adjustment('caster_level')is needed. But it turned out that that was broken, so I fixed that too.While I was at it, I also added two spells to Sorcerer that were created in #83088.
Fixes #83283.
Describe the solution
Don't throw away preexisting
temp_level_adjustmentinevaluate_opens_spellbook_data().Change Sorcerer to use
u_spellcasting_adjustment('caster_level', 'mod': 'magiclysm')andu_spellcasting_adjustment('caster_level', 'mod': 'sorcerer')Added the new spells by running
generate_code.py. Found and fixed minor error ingenerate_code.py.Changed Bloodrager code to only set the spell level adjustment once per mod.
Describe alternatives you've considered
Break this up into two or three pull requests? Not sure what is best practice here.
Testing
Made a Sorcerer with MoM spells before any changes, noticed Sorcerer spell bonuses were applied to all spells.
Made the .json changes, noticed Sorcerer spell bonuses were not applied to any spells at all.
Made C++ changes and compiled, noticed Sorcerer spell bonuses were applied only to the Magiclysm and Sorcerer spells as intended.
Additional context
@Standing-Storm might be happy to know that
spellcasting_adjustment('caster_level')is now working correctly.