Skip to content

simpleitk_timeseries_motion_correction install was removed from setup…#491

Merged
Gab-D-G merged 1 commit intomasterfrom
move_simpleitk_timeseries_motion_correction_dependency
Mar 27, 2026
Merged

simpleitk_timeseries_motion_correction install was removed from setup…#491
Gab-D-G merged 1 commit intomasterfrom
move_simpleitk_timeseries_motion_correction_dependency

Conversation

@Gab-D-G
Copy link
Copy Markdown
Collaborator

@Gab-D-G Gab-D-G commented Mar 27, 2026

….py as it does not exists on PyPi. It is instead installed through the .yml files, and listed in dependencies.txt.

Summary by CodeRabbit

  • Chores
    • Standardized package dependency specifications across build and environment configuration files.

….py as it does not exists on PyPi. It is instead installed through the .yml files, and listed in dependencies.txt.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8f2eed2d-cdf7-41dc-9dce-0032c7e3cc1d

📥 Commits

Reviewing files that changed from the base of the PR and between 90cda37 and 9c523e3.

📒 Files selected for processing (5)
  • Dockerfile
  • dependencies.txt
  • rabies_environment.dev.yml
  • rabies_environment.yml
  • setup.py
💤 Files with no reviewable changes (2)
  • Dockerfile
  • setup.py

📝 Walkthrough

Walkthrough

The pull request reorganizes the dependency declaration for simpleitk_timeseries_motion_correction across configuration files. The dependency is removed from setup.py and Dockerfile, added to conda environment files, and reformatted to use a PEP 508-style Git reference pinned to a specific commit.

Changes

Cohort / File(s) Summary
Build Configuration
Dockerfile
Removed git installation and separate pip install for simpleitk_timeseries_motion_correction, streamlining the build process by relying on environment-based dependency resolution.
Conda Environment Definitions
rabies_environment.dev.yml, rabies_environment.yml
Added git to Conda dependencies and added simpleitk_timeseries_motion_correction as a pip-installed package pinned to commit 8cc2b031c22df5cf8d01f75ec186570dd3ffb3e9.
Dependency Specifications
dependencies.txt, setup.py
Updated dependencies.txt to PEP 508-style Git reference format and removed simpleitk_timeseries_motion_correction from setup.py's REQUIRED list, consolidating dependency management into environment files.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Review python dependencies #488: Modifies the same simpleitk_timeseries_motion_correction dependency pinning across environment, Dockerfile, and setup configurations.

Suggested reviewers

  • gdevenyi

Poem

🐰 A dep moves house from setup to yml,
Git commit pinned, with steadfast will,
Dockerfile lightens, environment grows,
Dependencies flow where the conda wind blows! 🌪️

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing simpleitk_timeseries_motion_correction from setup.py due to PyPI unavailability, with the dependency moved to environment files instead.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch move_simpleitk_timeseries_motion_correction_dependency

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Gab-D-G Gab-D-G merged commit 97e7251 into master Mar 27, 2026
3 checks passed
@Gab-D-G Gab-D-G deleted the move_simpleitk_timeseries_motion_correction_dependency branch March 27, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant