London_ITP_Jan_2025 | FRANKLIN KAMELA | Module_Data_Flows | Book_Library | Sprint_2 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @halilibrahimcelik could you please review |
halilibrahimcelik
added
Review in progress
|
Hi Franklin, I couldn't catch up with you with your other PR's I've been incredibly busy lately. |
halilibrahimcelik
requested changes
Apr 3, 2025
debugging/book-library/script.js
Outdated
| author.value === null || | ||
| author.value === "" || | ||
| pages.value === null || | ||
| pages.value === "" |
There was a problem hiding this comment.
I'm still able to add books even if there is only empty space entered in the form field. Please check submit validation again
debugging/book-library/script.js
Outdated
| deleteCell.appendChild(delButton); | ||
| delButton.className = "btn btn-warning"; | ||
| delButton.innerHTML = "Delete"; | ||
| delButton.addEventListener("click", function () { | ||
| alert(`You've deleted title: ${myLibrary[i].title}`); |
There was a problem hiding this comment.
Okay here's a challenge for you. Once user click on delete button, you warn user that book is about to be deleted. It would be nice to have functionality that user also be able to change his mind and cancel this delete process.
Fradoka
added
Needs Review
|
Hi @halilibrahimcelik i amended my code to address your review comments. |
|
hi @halilibrahimcelik could you please review my code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.