generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 71
London_ITP_Jan_2025 | FRANKLIN KAMELA | Module_Data_Flows | Book_Library | Sprint_2 #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Fradoka
wants to merge
2
commits into
CodeYourFuture:main
Choose a base branch
from
Fradoka:sprint_2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,8 +6,8 @@ window.addEventListener("load", function (e) { | |
}); | ||
|
||
function populateStorage() { | ||
if (myLibrary.length == 0) { | ||
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); | ||
if (myLibrary.length === 0) { | ||
let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true); | ||
let book2 = new Book( | ||
"The Old Man and the Sea", | ||
"Ernest Hemingway", | ||
|
@@ -29,17 +29,23 @@ const check = document.getElementById("check"); | |
//via Book function and start render function | ||
function submit() { | ||
if ( | ||
title.value == null || | ||
title.value == "" || | ||
pages.value == null || | ||
pages.value == "" | ||
title.value === null || | ||
title.value === "" || | ||
author.value === null || | ||
author.value === "" || | ||
pages.value === null || | ||
pages.value === "" | ||
) { | ||
alert("Please fill all fields!"); | ||
return false; | ||
} else { | ||
let book = new Book(title.value, title.value, pages.value, check.checked); | ||
library.push(book); | ||
let newBook = new Book(title.value, author.value, pages.value, check.checked); | ||
myLibrary.push(newBook); | ||
render(); | ||
title.value = ""; | ||
author.value = ""; | ||
pages.value = null; | ||
check.checked = false; | ||
} | ||
} | ||
|
||
|
@@ -54,7 +60,7 @@ function render() { | |
let table = document.getElementById("display"); | ||
let rowsNumber = table.rows.length; | ||
//delete old table | ||
for (let n = rowsNumber - 1; n > 0; n-- { | ||
for (let n = rowsNumber - 1; n > 0; n--) { | ||
table.deleteRow(n); | ||
} | ||
//insert updated row and cells | ||
|
@@ -72,14 +78,16 @@ function render() { | |
|
||
//add and wait for action for read/unread button | ||
let changeBut = document.createElement("button"); | ||
changeBut.id = i; | ||
changeBut.className = "btn btn-success"; | ||
//changeBut.id = i; | ||
|
||
wasReadCell.appendChild(changeBut); | ||
let readStatus = ""; | ||
if (myLibrary[i].check == false) { | ||
if (myLibrary[i].check !== false) { | ||
readStatus = "Yes"; | ||
changeBut.className = "btn btn-success"; | ||
} else { | ||
readStatus = "No"; | ||
changeBut.className = "btn btn-danger"; | ||
} | ||
changeBut.innerText = readStatus; | ||
|
||
|
@@ -90,11 +98,11 @@ function render() { | |
|
||
//add delete button to every row and render again | ||
let delButton = document.createElement("button"); | ||
delBut.id = i + 5; | ||
deleteCell.appendChild(delBut); | ||
delBut.className = "btn btn-warning"; | ||
delBut.innerHTML = "Delete"; | ||
delBut.addEventListener("clicks", function () { | ||
//delButton.id = i + 5; | ||
deleteCell.appendChild(delButton); | ||
delButton.className = "btn btn-warning"; | ||
delButton.innerHTML = "Delete"; | ||
delButton.addEventListener("click", function () { | ||
alert(`You've deleted title: ${myLibrary[i].title}`); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay here's a challenge for you. Once user click on delete button, you warn user that book is about to be deleted. It would be nice to have functionality that user also be able to change his mind and cancel this delete process. |
||
myLibrary.splice(i, 1); | ||
render(); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still able to add books even if there is only empty space entered in the form field. Please check submit validation again
