West-Midlands ITP-Jan-2025 | Ifeanyi Madubugwu | Module-Data-Flow| Sprint -2| Book Library

[Elchacode]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[cjyuan]

Code is working. I think there are a few improvements you can still make.

[cjyuan]

When I checked the code in index.html at https://validator.w3.org/, it indicated some errors.

[Elchacode]

Hi CJ

have i fixed my html element and all has passed in https://validator.w3.org/,

[cjyuan]

In terms of input validation,

1. Can .value be null? (Do we need to check someInputElement.value == null?)
2. What if a user enters an invalid page number in the "pages" input field?

[Elchacode]

Hi Cj

i have refactor the code and have remove
title.value == null
author.value == null
page.value == null

[cjyuan]

Do we need this console.log() statement for the app to work?

[Elchacode]

Hi Cj

i have removed the console.log, i implemented that when i was debugging my code.

Thanks

[cjyuan]

Instead of deleting the table rows one by one, can you think of a more efficient way to remove all rows (except the <th>...</th>) in the table?

[Elchacode]

Hi Cj

i have refactor the code to clear all row except the header, and also sort myLibrary before rendering.

[cjyuan]

• With the way the book's title is assigned to an HTML element (line 73), a book with a title containing special character sequence such as <i> can possibly ruin the display.

• Is the value assigned to the id attribute of changeBut and delButton unique?

• Is there a need to assign an id attribute to delButton (line 92) or changeBut (line 79)?

• Can you think of a more consistent way to name the variables representing the two buttons, changeBut and delButton?

[Elchacode]

Hi Cj

on line 73, i have refactor the code to textContent instead of innerHTML,

i deleted the id attribute for the changeBut and delButton, and i also rename the variable to statusButton and deleteButton

[cjyuan]

On a separate note, it's considered good practice to check the boxes in the PR template (to confirm that the listed requirements have been met) and to include a brief description of the PR.

[cjyuan]

I didn't see any changes made based on my feedback.
If you have made changes on your computer, you need to push your changes to Github.