Skip to content

West-Midlands ITP-Jan-2025 | Ifeanyi Madubugwu | Module-Data-Flow| Sprint -2| Book Library #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

West-Midlands ITP-Jan-2025 | Ifeanyi Madubugwu | Module-Data-Flow| Sprint -2| Book Library #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4af0ca4
...
Elchacode Apr 9, 2025
f92ec56
refactor the delete button and also added author name to get the val…
Elchacode Apr 9, 2025
5cba6ac
refactor my html file to pass https://validator.w3.org/,
Elchacode Apr 22, 2025
e6df224
refactor my code according the Cj feedback
Elchacode Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
<!DOCTYPE html>
<html>
<html lang="en">

<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title> Library - Add and View Books</title>

<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
Expand All @@ -20,26 +19,26 @@
<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
<p>Add books to your virtual library..</p>
</div>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>

<div id="demo" class="collapse">
<div class="form-group">
<form id="book-form" class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
Expand Down Expand Up @@ -67,7 +66,7 @@ <h1>Library</h1>
class="btn btn-primary"
onclick="submit();"
/>
</div>
</form>
</div>

<table class="table" id="display">
Expand All @@ -91,6 +90,6 @@ <h1>Library</h1>
</tbody>
</table>

<script src="script.js"></script>
<script defer src="script.js"></script>
</body>
</html>
75 changes: 42 additions & 33 deletions debugging/book-library/script.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • With the way the book's title is assigned to an HTML element (line 73), a book with a title containing special character sequence such as <i> can possibly ruin the display.

  • Is the value assigned to the id attribute of changeBut and delButton unique?

  • Is there a need to assign an id attribute to delButton (line 92) or changeBut (line 79)?

  • Can you think of a more consistent way to name the variables representing the two buttons, changeBut and delButton?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Cj

on line 73, i have refactor the code to textContent instead of innerHTML,

i deleted the id attribute for the changeBut and delButton, and i also rename the variable to statusButton and deleteButton

Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ function populateStorage() {
myLibrary.push(book1);
myLibrary.push(book2);
render();

}
}

Expand All @@ -29,19 +30,29 @@ const check = document.getElementById("check");
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""

title.value.trim() === "" ||
author.value.trim() === "" ||
pages.value.trim() === ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
}
const pagesNumber = Number(pages.value.trim());
if (isNaN(pagesNumber) || pagesNumber <= 0) {
alert("Please enter a valid number of pages.");
return false;
}

let book = new Book(title.value, author.value, pagesNumber, check.checked);
myLibrary.push(book);
render();

}
}





function Book(title, author, pages, check) {
this.title = title;
Expand All @@ -54,9 +65,14 @@ function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}

table.innerHTML = table.rows[0].outerHTML;
// for (let n = rowsNumber - 1; n > 0; n-- ) {
// table.deleteRow(n);
// }

myLibrary.sort((a, b) => a.title.localeCompare(b.title));

//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
Expand All @@ -66,35 +82,28 @@ function render() {
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
//add and wait for action for read/unread button.
let statusButton = document.createElement("button");
statusButton.className = "btn btn-success";
wasReadCell.appendChild(statusButton);
let readStatus = myLibrary[i].check ? "Read" : "Unread";
statusButton.innerText = readStatus;

changeBut.addEventListener("click", function () {
statusButton.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
let deleteButton = document.createElement("button");
deleteCell.appendChild(deleteButton);
deleteButton.className = "btn btn-warning";
deleteButton.innerHTML = "Delete";
deleteButton.addEventListener("click", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
Expand Down