-
-
Notifications
You must be signed in to change notification settings - Fork 71
ITP-JAN-25 | LONDON | Bakytbek Sydykov | Module-Data-Flows | book-library #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Please remove any comments that are not required. This will make your code cleaner, easier to read and easier to maintain in the future.
-
Currently your application does not have a title in the browser tab (see screenshot). Can you update the application title to something more meaningful?

-
After adding a new book to the library, the form still contains the books details. If I want to add another book, I have to clear out the form fields. Can you update the application to clear out the fields after successfully adding a book to the library?
-
Please make sure to update the Changelist section of the PR with a short explanation of your changes.

Cleared form fields after successfully adding a book to the library. |
@Bahasyd Can you give a brief description to this PR in the "Changelist" section in the first comment (as requested by the reviewer)
|
this.pages = pages; | ||
this.check = check; | ||
} | ||
document.getElementById("title").value = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If code is outside of a function, it will only run when the script first loads.
For this application, it makes sense for the book form to be cleared after successful submission.
Can you review this code change, try it out locally and make the changes necessary to clear the form after a submit?
Learners, PR Template
Self checklist
Changelist
Explain my PR: Cleared form fields after successfully adding a book to the library.
The latest changes — I added the clearing of this line after the search.
Questions
Ask any questions you have for your reviewer.