Skip to content

ITP-JAN-25 | LONDON | Bakytbek Sydykov | Module-Data-Flows | book-library #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Bahasyd
Copy link

@Bahasyd Bahasyd commented Apr 22, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Explain my PR: Cleared form fields after successfully adding a book to the library.
The latest changes — I added the clearing of this line after the search.

Questions

Ask any questions you have for your reviewer.

@Bahasyd Bahasyd added the Needs Review Participant to add when requesting review label Apr 22, 2025
@Bahasyd Bahasyd self-assigned this Apr 22, 2025
@jenny-alexander jenny-alexander self-requested a review April 22, 2025 13:08
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Apr 22, 2025
Copy link

@jenny-alexander jenny-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please remove any comments that are not required. This will make your code cleaner, easier to read and easier to maintain in the future.

  2. Currently your application does not have a title in the browser tab (see screenshot). Can you update the application title to something more meaningful?

Screenshot 2025-04-22 at 12 47 55 PM
  1. After adding a new book to the library, the form still contains the books details. If I want to add another book, I have to clear out the form fields. Can you update the application to clear out the fields after successfully adding a book to the library?

  2. Please make sure to update the Changelist section of the PR with a short explanation of your changes.

Screenshot 2025-04-20 at 8 50 42 PM

@jenny-alexander jenny-alexander added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 22, 2025
@Bahasyd Bahasyd added the Complete Volunteer to add when work is complete and review comments have been addressed label Apr 23, 2025
@Bahasyd
Copy link
Author

Bahasyd commented Apr 23, 2025

Cleared form fields after successfully adding a book to the library.

@Bahasyd Bahasyd added the Needs Review Participant to add when requesting review label Apr 23, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Apr 23, 2025

@Bahasyd Can you give a brief description to this PR in the "Changelist" section in the first comment (as requested by the reviewer)

Please make sure to update the Changelist section of the PR with a short explanation of your changes.

@Bahasyd Bahasyd requested a review from jenny-alexander April 23, 2025 11:37
@cjyuan cjyuan removed the Needs Review Participant to add when requesting review label Apr 23, 2025
this.pages = pages;
this.check = check;
}
document.getElementById("title").value = "";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If code is outside of a function, it will only run when the script first loads.
For this application, it makes sense for the book form to be cleared after successful submission.

Can you review this code change, try it out locally and make the changes necessary to clear the form after a submit?

@jenny-alexander jenny-alexander removed the Complete Volunteer to add when work is complete and review comments have been addressed label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants