Skip to content

ITP-JAN-25 | LONDON | Bakytbek Sydykov | Module-Data-Flows | book-library #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 4 additions & 24 deletions debugging/book-library/index.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html>
<head>
<title> </title>
<title>Book library</title>
<meta
charset="utf-8"
name="viewport"
Expand Down Expand Up @@ -30,21 +30,9 @@ <h1>Library</h1>
<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<input type="text" class="form-control" id="title" required />
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<input type="text" class="form-control" id="author" required />
<label for="pages">Pages:</label>
<input
type="number"
Expand Down Expand Up @@ -80,15 +68,7 @@ <h1>Library</h1>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
<tbody class="tBody"></tbody>
</table>

<script src="script.js"></script>
Expand Down
129 changes: 47 additions & 82 deletions debugging/book-library/script.js
Original file line number Diff line number Diff line change
@@ -1,103 +1,68 @@
let myLibrary = [];

window.addEventListener("load", function (e) {
populateStorage();
window.addEventListener("load", () => {
if (myLibrary.length === 0) {
myLibrary.push(new Book("Robinson Crusoe", "Daniel Defoe", 252, true));
myLibrary.push(new Book("The Old Man and the Sea", "Ernest Hemingway", 127, false));
}
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
function Book(title, author, pages, read) {
this.title = title;
this.author = author;
this.pages = pages;
this.read = read;
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
const title = document.getElementById("title").value.trim();
const author = document.getElementById("author").value.trim();
const pages = parseInt(document.getElementById("pages").value);
const read = document.getElementById("check").checked;

if (!title || !author || isNaN(pages) || pages <= 0) {
alert("Please fill in all fields correctly.");
return;
}

myLibrary.push(new Book(title, author, pages, read));
render();
}

function Book(title, author, pages, check) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
}
document.getElementById("title").value = "";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If code is outside of a function, it will only run when the script first loads.
For this application, it makes sense for the book form to be cleared after successful submission.

Can you review this code change, try it out locally and make the changes necessary to clear the form after a submit?

document.getElementById("author").value = "";
document.getElementById("pages").value = "";
document.getElementById("check").checked = false;


function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
const tBody = document.querySelector(".tBody");
tBody.innerHTML = "";

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
myLibrary.forEach((book, index) => {
const row = tBody.insertRow();

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
row.insertCell().textContent = book.title;
row.insertCell().textContent = book.author;
row.insertCell().textContent = book.pages;

const readCell = row.insertCell();
const toggleBtn = document.createElement("button");
toggleBtn.textContent = book.read ? "Yes" : "No";
toggleBtn.addEventListener("click", () => {
book.read = !book.read;
render();
});
readCell.appendChild(toggleBtn);

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
const deleteCell = row.insertCell();
const deleteBtn = document.createElement("button");
deleteBtn.textContent = "Delete";
deleteBtn.addEventListener("click", () => {
myLibrary.splice(index, 1);
render();
});
}
deleteCell.appendChild(deleteBtn);
});
}
28 changes: 24 additions & 4 deletions debugging/book-library/style.css
Original file line number Diff line number Diff line change
@@ -1,19 +1,39 @@
body {
background-color: #f9f9f9;
font-family: Arial, sans-serif;
padding-bottom: 30px;
}

.form-group {
width: 400px;
height: 300px;
align-self: left;
padding-left: 20px;
}

.jumbotron {
background-color: #343a40;
color: white;
padding: 2rem;
margin-bottom: 2rem;
}
.btn {
display: block;
font-size: 0.9rem;
}
h1 {
font-size: 3rem;
margin-bottom: 0.5rem;
}

.form-check-label {
padding-left: 20px;
margin: 5px 0px 5px 0px;
}

#demo {
background-color: #ffffff;
padding: 20px;
border-radius: 8px;
margin: 20px 0;
box-shadow: 0 2px 6px rgba(0, 0, 0, 0.1);
}
button.btn-info {
margin: 20px;
}