-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CYF_Glasgow | Mansoor Munawar | Module-Onboarding | WEEK 2 | Form control #253
base: main
Are you sure you want to change the base?
Conversation
…so added line break to make the form easier to read
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is okay, I think you need to write better commit messages, consider reading through this article How to write better git commit messages, a step by step guide. Also I think your html indentation and spacing just needs to be improved a little bit, consider reading through this article How to indent HTML code and why it's important. Good job!
Self checklist
Changelist
Briefly explain your PR.
I created a form which asks for user name, email, size of t-shirt and color of t-shirt.
All of the form elements are required before the form can be submitted.
I have used semantic html elements such as header, main, footer.
My form meets 100% accessibility requirement.
Questions
Ask any questions you have for your reviewer.