Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYF_Glasgow | Mansoor Munawar | Module-Onboarding | WEEK 2 | Form control #253

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MansoorM11
Copy link

Self checklist

  • [ ✔️] I have committed my files one by one, on purpose, and for a reason
  • [ ✔️] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • [ ✔️] I have tested my changes
  • [ ✔️] My changes follow the style guide
  • [ ✔️] My changes meet the requirements of this task

Changelist

Briefly explain your PR.
I created a form which asks for user name, email, size of t-shirt and color of t-shirt.
All of the form elements are required before the form can be submitted.
I have used semantic html elements such as header, main, footer.
My form meets 100% accessibility requirement.

Questions

Ask any questions you have for your reviewer.

@MansoorM11 MansoorM11 added the Needs Review Participant to add when requesting review label Feb 6, 2025
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit bf1081d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-onboarding-module/deploys/67d6fd63cef4f90008c8c7a0
😎 Deploy Preview https://deploy-preview-253--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@A-O-Emmanuel A-O-Emmanuel added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay, I think you need to write better commit messages, consider reading through this article How to write better git commit messages, a step by step guide. Also I think your html indentation and spacing just needs to be improved a little bit, consider reading through this article How to indent HTML code and why it's important. Good job!

@A-O-Emmanuel A-O-Emmanuel added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 12, 2025
@MansoorM11 MansoorM11 added the Complete Participant to add when work is complete and review comments have been addressed label Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants