Skip to content

CYF_Glasgow | Mansoor Munawar | Module-Onboarding | WEEK 2 | Form control #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

CYF_Glasgow | Mansoor Munawar | Module-Onboarding | WEEK 2 | Form control #253

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eed6b09
added a label and input field for name and email within the form element
MansoorM11 Feb 6, 2025
5f370d2
added label and select elements for t-shirt color and t-shirt size.Al…
MansoorM11 Feb 6, 2025
361501b
added a submit button to submit the form.
MansoorM11 Feb 6, 2025
8091724
found an error in my html and removed it.
MansoorM11 Feb 6, 2025
bf1081d
fixed html indentation and spacing
MansoorM11 Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 44 additions & 6 deletions Form-Controls/index.html
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay, I think you need to write better commit messages, consider reading through this article How to write better git commit messages, a step by step guide. Also I think your html indentation and spacing just needs to be improved a little bit, consider reading through this article How to indent HTML code and why it's important. Good job!

Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,53 @@ <h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<label for="name">Name</label>
<br />
<input
type="text"
name="name"
id="name"
placeholder="Name"
required
minlength="2"
/>
<br />
<label for="email">Email</label>
<br />
<input
type="email"
name="email"
id="email"
placeholder="Email Address"
required
/>
<br />
<label for="t-shirt">Choose a color of t-shirt:</label>
<br />
<select id="t-shirt" name="t-shirt" required>
<option value="" disabled selected>Please choose an option</option>
<option value="black">Black</option>
<option value="green">Green</option>
<option value="blue">Blue</option>
</select>
<br />
<label for="size">Size of t-shirt:</label>
<br />
<select id="size" name="size" required>
<option value="" disabled selected>Please choose an option</option>
<option value="xs">XS</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>
<br />
<button type="submit">Submit</button>
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
<h2>By Mansoor Munawar</h2>
</footer>
</body>
</html>