ITP-MAY-25- LONDON | KEBROM-GEBRETINSAY | Module-Onboarding - FORM-CONTROL #694
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I had indentation error in the previous branch of form control. I have tried to fix it. |
| <form action="/submit-order" method="POST"> | ||
|
|
||
| <label for="fname">First Name:</label><br /> | ||
| <input type="text" id="fname" name="fname" required pattern="[A-Za-z\s]+" |
There was a problem hiding this comment.
Did you plan to accept a name that contains only a single space character?
There was a problem hiding this comment.
Not only a single space. The pattern allows single or multiple space character.
There was a problem hiding this comment.
Why do you want to recognise a name containing only space characters as valid name?
There was a problem hiding this comment.
Because name with only space characters is valid under the pattern.
There was a problem hiding this comment.
and also the pattern accepts any combination of letters and whitespace,
cjyuan
added
Reviewed
|
Your implementation is very solid. Good job. |
Learners, PR Template
Self checklist
Changelist
The purpose of PR is facilitating code review and collaboration among developers. It allows team members to discuss proposed changes, ensuring code quality and adherence to project standards. Additionally, PRs serve as documentation of modifications and enable automated testing to prevent bugs in the codebase
Questions
Ask any questions you have for your reviewer.