Skip to content

ITP-MAY-25- LONDON | KEBROM-GEBRETINSAY | Module-Onboarding - FORM-CONTROL #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ITP-MAY-25- LONDON | KEBROM-GEBRETINSAY | Module-Onboarding - FORM-CONTROL #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 64 additions & 24 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,67 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
</footer>
</body>

<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My Form Exercise</title>
<meta name="description" content="T-shirt order form" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>

<body>
<header>
<h1>Order Your T-shirt</h1>
</header>

<main>
<form action="/submit-order" method="POST">

<label for="fname">First Name:</label><br />
<input type="text" id="fname" name="fname" required pattern="[A-Za-z\s]+"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you plan to accept a name that contains only a single space character?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only a single space. The pattern allows single or multiple space character.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to recognise a name containing only space characters as valid name?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because name with only space characters is valid under the pattern.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also the pattern accepts any combination of letters and whitespace,

title="Name should only contain letters and spaces." /><br /><br />


<label for="lname">Last Name:</label><br />
<input type="text" id="lname" name="lname" required pattern="[A-Za-z\s]+"
title="Name should only contain letters and spaces." /><br /><br />


<label for="email">Email:</label><br />
<input type="email" id="email" name="email" required pattern="[a-z0-9._%+-]+@[a-z0-9.-]+\.[a-z]{2,}$"
title="Enter a valid email address." /><br /><br />


<label for="color">Select Color:</label><br />
<select id="color" name="color" required>
<option value="">Select color</option>
<option value="red">Red</option>
<option value="green">Green</option>
<option value="blue">Blue</option>
<option value="yellow">Yellow</option>
<option value="orange">Orange</option>
<option value="purple">Purple</option>
</select><br /><br />


<label for="size">Select Size:</label><br />
<select id="size" name="size" required>
<option value="">Select size</option>
<option value="xs">XS</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select><br /><br />


<button type="submit">Order Now</button>
</form>
</main>

<footer>
<h2>By Kebrom Gebretinsay</h2>
</footer>
</body>
</html>