-
-
Notifications
You must be signed in to change notification settings - Fork 266
London | May-2025 | Victoria Scott | Form edits #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
London | May-2025 | Victoria Scott | Form edits #707
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is well-indented, and your form implementation is pretty solid. Good job!
-
According to https://validator.w3.org/, there is a warning in your code. Can you fix it?
-
To follow best practices, can you update your PR description by carrying out the following actions?
- Check the items in the Self-Checklist to confirm your pull request meets the guidelines
- Provide a brief description (under the "Changelist" section) summarizing the purpose of the PR and the changes you’ve made
-
A PR branch should include only the changes relevant to the specific task or feature it addresses. Are the modified files in the "Wireframe" folder related to your form implementation? If not, you should revert the changes made to those files in order to make this branch clean.
One way to revert the changes made to the files in the "Wireframe" folder is to replace them by the version of the files in your main
branch. (The files in main
branch are unmodified since you forked them from CYF).
- You can download the three files in your main
branch from
https://github.com/VictoriaScottCodes/Module-Onboarding/tree/main/Wireframe
- While you are in the Form-edits
branch (this branch), copy the downloaded files to the "Wireframe" subfolder (in order to replace the files).
- Commit the changes and then push the commit to Github.
…tml files from main branch
Lighthouse score is now 100. Good job. I will mark this PR as "Complete" first. You can continue working on fixing this branch (for practice)
|
Learners, PR Template
Self checklist
Changelist
Ran through validator, edited errors (trailing slashes deleted)
Questions
Ask any questions you have for your reviewer.