London | May-2025 | Victoria Scott | Form edits

[VictoriaScottCodes]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Ran through validator, edited errors (trailing slashes deleted)

Questions

Ask any questions you have for your reviewer.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	fd459ef
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/68456b5a4c130100080cd00b
😎 Deploy Preview	https://deploy-preview-707--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[cjyuan]

Code is well-indented, and your form implementation is pretty solid. Good job!

1. According to https://validator.w3.org/, there is a warning in your code. Can you fix it?

2. To follow best practices, can you update your PR description by carrying out the following actions?

   • Check the items in the Self-Checklist to confirm your pull request meets the guidelines
   • Provide a brief description (under the "Changelist" section) summarizing the purpose of the PR and the changes you’ve made

3. A PR branch should include only the changes relevant to the specific task or feature it addresses. Are the modified files in the "Wireframe" folder related to your form implementation? If not, you should revert the changes made to those files in order to make this branch clean.
   

One way to revert the changes made to the files in the "Wireframe" folder is to replace them by the version of the files in your main branch. (The files in main branch are unmodified since you forked them from CYF).
- You can download the three files in your main branch from
https://github.com/VictoriaScottCodes/Module-Onboarding/tree/main/Wireframe
- While you are in the Form-edits branch (this branch), copy the downloaded files to the "Wireframe" subfolder (in order to replace the files).
- Commit the changes and then push the commit to Github.

[cjyuan]

Changes look good.

1. Without CSS, the Lighthouse Accessibility score of your page is not yet 100. Can you improve the score to 100?
   

2. This branch still contains unrelated changes in the "Wireframe" folder. Can you revert the change made in the "Wireframe" folder on this branch?

---

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

• Reply to their feedback.
  • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
  • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
• Replace the "Reviewed" label by a "Needs review" label
  • Without this label, the reviewer would not know if your changes is ready to be reviewed.

[cjyuan]

Lighthouse score is now 100. Good job. I will mark this PR as "Complete" first.

You can continue working on fixing this branch (for practice)

• The branch now contains an extra image in the "Wireframe" folder. You can see which files are modified in this branch here: https://github.com/CodeYourFuture/Module-Onboarding/pull/707/files

• Wireframe/index.html and Wireframe/README.md are still considered changed files (by Git) because there is an extra space on the last line in the original files. (Replace file instead of replacing file content is safer).