Skip to content

London | May-2025 | Victoria Scott | Form edits #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions Form-Controls/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@

<!--{{<objectives>}}>-->

- [ ] Interpret requirements and check against a list of criteria
- [ ] Write a valid form
- [ ] Test with Devtools
- [ ] Refactor using Devtools
- [x] Interpret requirements and check against a list of criteria
- [x] Write a valid form
- [x] Test with Devtools
- [x] Refactor using Devtools
<!--{{<objectives>}}>-->

## Task
Expand All @@ -30,18 +30,18 @@ Do not write a form action for this project.

Let's write out our testable criteria. Check each one off as you complete it.

- [ ] I have used HTML only.
- [x] I have used HTML only.
- [x] I have not used any CSS or JavaScript.

### HTML

- [ ] My form is semantic html.
- [ ] All inputs have associated labels.
- [ ] My Lighthouse Accessibility score is 100.
- [ ] I require a valid name. I have defined a valid name as a text string of two characters or more.
- [ ] I require a valid email.
- [ ] I require one colour from a defined set of 3 colours.
- [ ] I require one size from a defined set of 6 sizes.
- [x] My form is semantic html.
- [x] All inputs have associated labels.
- [x] My Lighthouse Accessibility score is 100.
- [x] I require a valid name. I have defined a valid name as a text string of two characters or more.
- [x] I require a valid email.
- [x] I require one colour from a defined set of 3 colours.
- [x] I require one size from a defined set of 6 sizes.

## Resources

Expand Down
138 changes: 113 additions & 25 deletions Form-Controls/index.html
Original file line number Diff line number Diff line change
@@ -1,27 +1,115 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
</footer>
</body>
</html>
<head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<title>My form exercise</title>
<meta name="viewport" content="width=device-width, initial-scale=1">
</head>
<body>
<header>
<h1>T-shirt Pick</h1>
</header>

<main>
<form action="/my-handling-form-page" method="post" aria-label="T-shirt selection form">
<div>
<label for="name">Enter your name:</label><br>
<input type="text" id="name" name="user_name" required aria-required="true" pattern=".*\S.*"
title="Name must contain at least one non-space character">
</div>

<br>

<div>
<label for="mail">Enter your email:</label><br>
<input type="email" id="mail" name="user_email" required aria-required="true">
</div>

<br>

<fieldset>
<legend>What colour T-shirt would you like?</legend>
<div>
<label for="black">
<input type="radio" id="black" name="colour" value="Black" required>
Black
</label>
</div>
<br>
<div>
<label for="white">
<input type="radio" id="white" name="colour" value="White">
White
</label>
</div>
<br>
<div>
<label for="grey">
<input type="radio" id="grey" name="colour" value="Grey">
Grey
</label>
</div>
</fieldset>

<br>

<fieldset>
<legend>What size do you want?</legend>

<div>
<label for="size-xs">
<input type="radio" id="size-xs" name="size" value="XS" required>
XS
</label>
</div>
<br>
<div>
<label for="size-s">
<input type="radio" id="size-s" name="size" value="S">
S
</label>
</div>
<br>
<div>
<label for="size-m">
<input type="radio" id="size-m" name="size" value="M">
M
</label>
</div>
<br>
<div>
<label for="size-l">
<input type="radio" id="size-l" name="size" value="L">
L
</label>
</div>
<br>
<div>
<label for="size-xl">
<input type="radio" id="size-xl" name="size" value="XL">
XL
</label>
</div>
<br>
<div>
<label for="size-xxl">
<input type="radio" id="size-xxl" name="size" value="XXL">
XXL
</label>
</div>
</fieldset>

<br>

<div>
<button type="submit" aria-label="Submit your T-shirt selection">Submit</button>
</div>
</form>
</main>

<footer>
<h2>By Victoria</h2>
</footer>
</body>
</html>
Binary file added Wireframe/Adobe Express - file.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion Wireframe/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ There are some provided HTML and CSS files you can use to get started. You can u

- [Wireframe](https://www.productplan.com/glossary/wireframe/)
- [Semantic HTML](https://www.w3schools.com/html/html5_semantic_elements.asp)
- [:first-child](https://developer.mozilla.org/en-US/docs/Web/CSS/:first-child)
- [:first-child](https://developer.mozilla.org/en-US/docs/Web/CSS/:first-child)
2 changes: 1 addition & 1 deletion Wireframe/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ <h2>Title</h2>
</p>
</footer>
</body>
</html>
</html>