Clean-up GLBuffer interface, use DSA #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VReaperV
added
T-Improvement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
VReaperV
force-pushed
the
dsa-buffers
branch
8 times, most recently
from
91cc56d to
8e4eb7a
Compare
|
Rebased, doesn't require #1507 anymore. |
|
LGTM, no diffs in my tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GLBufferhas started to become unwieldy when setting up buffers, so I cleaned up its interface and made it use Direct State Access versions of the buffer commands where possible instead. These commands allow modyfing buffers without actually binding them, which makes it much easier. I've also removed a lot of duplicate code fromGLBufferitself, as well as the derivative buffers.glBufferDatahas been moved toGLBuffer, in line with the other buffer functions.Cleaned up buffer binding points as well, now they use an enum, and the shaders use defines for it.
Moved buffer init/free to a more appropriate location as well.
Also NUKED the unused
GLIndirectBufferand movedGLIndirectCommandtoMaterialSystem.h.