Translate user-facing messages from Russian to English for better reach#14
Open
T4ras123 wants to merge 3 commits intoDaniilDonskoy:masterfrom
Open
Translate user-facing messages from Russian to English for better reach#14T4ras123 wants to merge 3 commits intoDaniilDonskoy:masterfrom
T4ras123 wants to merge 3 commits intoDaniilDonskoy:masterfrom
Conversation
Owner
|
Okay, but try to put all text messages into a separate json file (preferably several, at i18n/en.json, i18n/ru.json). Write a class to extract messages from .json files and based on the language that will be written by the developer in .env in the BOT_LANGUAGE variable. You can cache the value of a language variable using lru_cache, for example (just remove the time limit). Also add documentation to the README for properties (add an example using BOT_LANGUAGE, it's easy). |
Author
|
Alright, imma do that. Give me some time |
…for user messages
Owner
|
Good, I'll look at everything soon and accept it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translated everything to english to allow non-russian speaking users to deploy this template