Repository navigation
ci(contributors): solo en el upstream (en el fork daba 404 en cada merge) - #11
Merged
Merged
Conversation
El generador arma CONTRIBUTORS.md con los PR del repo donde corre y contributors-extra.json lista PR del upstream (#156…), que en el fork no existen. Si pasara, reemplazaría a los contribuidores del upstream por los PR del fork. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DannyBaanks
added
the
no-visual-change
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Cada merge al fork disparaba Update contributors y fallaba así:
El workflow viene del upstream. Arma
CONTRIBUTORS.mdcon los PR del repo donde corre, y.github/contributors-extra.jsonlista PR del upstream (#156, …) que en el fork no existen. Si alguna vez pasara, sería peor, porque abriría un PR que cambia a los contribuidores del upstream por los 10 PR del fork.El job ahora solo corre cuando
github.repository == 'chaitanyagiri/munder-difflin'. En el upstream se comporta igual que antes.Type of change
Evidence
Before
Runs "Update contributors" en rojo en los merges de #5, #6, #7, #8 y #10.
After
En el fork el job sale como skipped. La condición se validó con YAML:
github.repository == 'chaitanyagiri/munder-difflin' && (github.event_name != 'pull_request_target' || github.event.pull_request.merged == true).🤖 Generated with Claude Code