Repository navigation
fix(seguridad): lockfile en sync, fuera localtunnel, receptores en loopback, tests en CI - #3
Merged
Merged
Conversation
…opback, tests en CI - package-lock.json se desincronizó (faltaba ws@8.21.3 de @openai/agents-core) y `npm ci` fallaba en CI y en release. Regenerado. - localtunnel no se importa en ningún lado y arrastraba axios vulnerable (varios GHSA high). Eliminado junto con @types/localtunnel. - hono sube a 4.13.9 (npm audit fix, sin breaking). - WebhookServer y SlackWebhookServer escuchaban en todas las interfaces; tunnelmole reenvía a localhost, así que ahora se bindean a 127.0.0.1 como ya hacían controlChannel e integrationBroker. Test nuevo. - CI corre la suite de tests (test:focused + tests del CLI munder). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141jpRihLcQWr34jq6mvC7b
Contributor
🚫 This PR is missing its before/after evidenceEvery pull request here has to show its work. Screenshots or a short screen recording, before the change and after it.
How to fix it: edit the description, keep the A bug fix with no visible surface still needs it: show the failing behaviour, then the same steps passing. A terminal recording is fine. Genuinely nothing to show — a CI tweak, a typo, a dependency bump? A maintainer can apply the |
6 tasks done
DannyBaanks
pushed a commit
that referenced
this pull request
Sep 25, 2026
…tunnel, receptores loopback, tests en CI Conflictos en slack/webhook resueltos conservando el bind a 127.0.0.1. Todos los tests corriendo en esta máquina antes de direct.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
PR 0 de la serie de la auditoría. Arregla los puntos #1, #3, #4 y #11:
package-lock.jsonestaba desincronizado (faltabaws@8.21.3, que pide@openai/agents-core) ynpm cifallaba en CI y en release. Regenerado.localtunnelno se importa en ningún lado y arrastrabaaxios <=0.32(varios GHSA high). Eliminado junto con@types/localtunnel.honosube a 4.13.9 connpm audit fix(sin breaking).WebhookServerySlackWebhookServerescuchaban en todas las interfaces. tunnelmole reenvía alocalhost, así que ahora escuchan solo en127.0.0.1, como ya hacíancontrolChanneleintegrationBroker.Tests:npm ci, build,test:focusedy los tests del CLImunder(link + avatar).proveedor.test.cjsqueda fuera porque pidesudoy se cuelga sin terminal.Sigue pendiente:
toml(high, víatunnelmole) no tiene versión parcheada. Solo parsea el config local de tunnelmole, que es entrada confiable.Type of change
Evidence
Before
npm ci→Missing: ws@8.21.3 from lock file(EUSAGE)npm audit --omit=dev→ 5 vulnerabilidades (1 moderate, 4 high): axios, hono, tomltest/public-listeners-loopback.test.cjs→# pass 0 / # fail 2(los dos servidores escuchan en::/0.0.0.0)After
npm ci --dry-run→ OK (lockfile en sync)npm audit --omit=dev→ 2 high, las dos portomlvíatunnelmole(sin parche publicado)test/public-listeners-loopback.test.cjs→# pass 2 / # fail 0http.get({hostname:'localhost'})(lo que usa tunnelmole) llega a un servidor que escucha solo en127.0.0.1How I tested it
npm run typecheck:node, el test nuevo antes y después del cambio (rojo → verde),node --test tools/munder/link.test.cjs tools/munder/avatar.test.cjs(9/9). El jobTestscorre enmacos-latestcon módulos nativos compilados.Checklist
npm run typecheckpasa.🤖 Generated with Claude Code
Generated by Claude Code