-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-332: disable fence #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 inline comment
also in service/src/main/resources/providers.yml, remove instances of google_credentials
scope
@@ -19,32 +18,22 @@ | |||
@Slf4j | |||
public class FenceProviderService extends ProviderService { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this class can go away and use TokenProviderService
instead.
Bonus points: merge TokenProviderService
with PassportProviderService
, remove the big switch statement in OauthApiController.createLink
, drive the decision about whether or not to get a passport from either a new config setting for a provider or from the existence of ga4gh_passport_v1
scope.
|
@dvoet I have removed I am game to tackle merging |
Jira: https://broadworkbench.atlassian.net/browse/CORE-332
What:
Why:
Gen3 wants to stop supporting this feature on their end; therefore, ECM needs to stop calling Gen3.
Notes:
I may have missed some implementation code which can still be deleted. Do you see anything else that should be deleted? This PR is already removing quite a lot.