Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-332: disable fence #253

Merged
merged 17 commits into from
Mar 7, 2025
Merged

CORE-332: disable fence #253

merged 17 commits into from
Mar 7, 2025

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Mar 5, 2025

Jira: https://broadworkbench.atlassian.net/browse/CORE-332

What:

  • Fence service account support is removed from ECM to stop calling Gen3
  • ECM returns a 404 to any downstream services requesting a fence service account key
  • Deleted (lots of) implementation code which previously supported fence keys

Why:

Gen3 wants to stop supporting this feature on their end; therefore, ECM needs to stop calling Gen3.

Notes:

I may have missed some implementation code which can still be deleted. Do you see anything else that should be deleted? This PR is already removing quite a lot.

@davidangb davidangb marked this pull request as ready for review March 6, 2025 20:36
@davidangb davidangb requested a review from a team as a code owner March 6, 2025 20:36
@davidangb davidangb requested review from dvoet and kevinmarete March 6, 2025 20:36
Copy link
Contributor

@dvoet dvoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 inline comment

also in service/src/main/resources/providers.yml, remove instances of google_credentials scope

@@ -19,32 +18,22 @@
@Slf4j
public class FenceProviderService extends ProviderService {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this class can go away and use TokenProviderService instead.

Bonus points: merge TokenProviderService with PassportProviderService, remove the big switch statement in OauthApiController.createLink, drive the decision about whether or not to get a passport from either a new config setting for a provider or from the existence of ga4gh_passport_v1 scope.

Copy link

sonarqubecloud bot commented Mar 7, 2025

@davidangb
Copy link
Contributor Author

@dvoet I have removed google_credentials scopes in provider config, and removed FenceProviderService entirely in favor of TokenProviderService.

I am game to tackle merging TokenProviderService with PassportProviderService … but how about doing that in a separate PR, since this one is already pretty big?

@davidangb davidangb requested a review from dvoet March 7, 2025 13:58
@davidangb davidangb merged commit 2a50b7c into dev Mar 7, 2025
14 checks passed
@davidangb davidangb deleted the da_CORE-332_disableFence branch March 7, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants