Fix NPE in AppSecConfigServiceImpl #9165

manuel-alvarez-alvarez · 2025-07-11T23:49:14Z

What Does This Do

Fixes NPE in AppSecConfigServiceImpl when receiving RC payloads without being properly initialized.

Motivation

In the last release AppSecConfigServiceImpl has been modified to be lazy initializable which is causing issues when receiving some RC payloads.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-07-12T00:23:57Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/fix-appsec-config-service-npe
git_commit_date	1752513413	1752567447
git_commit_sha	`562e533`	`9a188f8`
release_version	1.52.0-SNAPSHOT~562e53388e	1.52.0-SNAPSHOT~9a188f8669

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1752569250	1752569250
ci_job_id	1028533323	1028533323
ci_pipeline_id	70546546	70546546
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-mwkvp400 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-mwkvp400 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~9a188f8669, baseline=1.52.0-SNAPSHOT~562e53388e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.004 s) : 0, 1003611
Total [baseline] (10.64 s) : 0, 10639579
Agent [candidate] (994.12 ms) : 0, 994120
Total [candidate] (10.675 s) : 0, 10674975
section appsec
Agent [baseline] (1.173 s) : 0, 1173324
Total [baseline] (10.787 s) : 0, 10786637
Agent [candidate] (1.178 s) : 0, 1177560
Total [candidate] (10.82 s) : 0, 10820269
section iast
Agent [baseline] (1.131 s) : 0, 1131476
Total [baseline] (10.831 s) : 0, 10831124
Agent [candidate] (1.132 s) : 0, 1131685
Total [candidate] (10.831 s) : 0, 10831451
section profiling
Agent [baseline] (1.24 s) : 0, 1240357
Total [baseline] (10.964 s) : 0, 10964463
Agent [candidate] (1.246 s) : 0, 1245511
Total [candidate] (10.997 s) : 0, 10996688

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.004 s	-
Agent	appsec	1.173 s	169.713 ms (16.9%)
Agent	iast	1.131 s	127.865 ms (12.7%)
Agent	profiling	1.24 s	236.746 ms (23.6%)
Total	tracing	10.64 s	-
Total	appsec	10.787 s	147.059 ms (1.4%)
Total	iast	10.831 s	191.545 ms (1.8%)
Total	profiling	10.964 s	324.884 ms (3.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	994.12 ms	-
Agent	appsec	1.178 s	183.44 ms (18.5%)
Agent	iast	1.132 s	137.565 ms (13.8%)
Agent	profiling	1.246 s	251.391 ms (25.3%)
Total	tracing	10.675 s	-
Total	appsec	10.82 s	145.293 ms (1.4%)
Total	iast	10.831 s	156.476 ms (1.5%)
Total	profiling	10.997 s	321.713 ms (3.0%)

gantt
    title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~9a188f8669, baseline=1.52.0-SNAPSHOT~562e53388e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.078 ms) : 0, 694078
BytebuddyAgent [candidate] (685.908 ms) : 0, 685908
GlobalTracer [baseline] (243.075 ms) : 0, 243075
GlobalTracer [candidate] (242.116 ms) : 0, 242116
AppSec [baseline] (30.462 ms) : 0, 30462
AppSec [candidate] (30.397 ms) : 0, 30397
Debugger [baseline] (6.029 ms) : 0, 6029
Debugger [candidate] (5.963 ms) : 0, 5963
Remote Config [baseline] (678.03 µs) : 0, 678
Remote Config [candidate] (673.684 µs) : 0, 674
Telemetry [baseline] (8.231 ms) : 0, 8231
Telemetry [candidate] (8.209 ms) : 0, 8209
section appsec
BytebuddyAgent [baseline] (708.422 ms) : 0, 708422
BytebuddyAgent [candidate] (710.353 ms) : 0, 710353
GlobalTracer [baseline] (234.833 ms) : 0, 234833
GlobalTracer [candidate] (235.927 ms) : 0, 235927
AppSec [baseline] (171.222 ms) : 0, 171222
AppSec [candidate] (172.366 ms) : 0, 172366
Debugger [baseline] (5.724 ms) : 0, 5724
Debugger [candidate] (5.778 ms) : 0, 5778
Remote Config [baseline] (608.197 µs) : 0, 608
Remote Config [candidate] (615.44 µs) : 0, 615
Telemetry [baseline] (7.997 ms) : 0, 7997
Telemetry [candidate] (8.122 ms) : 0, 8122
IAST [baseline] (23.573 ms) : 0, 23573
IAST [candidate] (23.464 ms) : 0, 23464
section iast
BytebuddyAgent [baseline] (805.992 ms) : 0, 805992
BytebuddyAgent [candidate] (805.867 ms) : 0, 805867
GlobalTracer [baseline] (232.748 ms) : 0, 232748
GlobalTracer [candidate] (232.746 ms) : 0, 232746
AppSec [baseline] (29.575 ms) : 0, 29575
AppSec [candidate] (29.116 ms) : 0, 29116
Debugger [baseline] (5.721 ms) : 0, 5721
Debugger [candidate] (5.738 ms) : 0, 5738
Remote Config [baseline] (578.179 µs) : 0, 578
Remote Config [candidate] (587.339 µs) : 0, 587
Telemetry [baseline] (7.891 ms) : 0, 7891
Telemetry [candidate] (7.862 ms) : 0, 7862
IAST [baseline] (28.191 ms) : 0, 28191
IAST [candidate] (28.922 ms) : 0, 28922
section profiling
BytebuddyAgent [baseline] (674.418 ms) : 0, 674418
BytebuddyAgent [candidate] (676.912 ms) : 0, 676912
GlobalTracer [baseline] (360.683 ms) : 0, 360683
GlobalTracer [candidate] (362.078 ms) : 0, 362078
AppSec [baseline] (31.69 ms) : 0, 31690
AppSec [candidate] (34.238 ms) : 0, 34238
Debugger [baseline] (10.906 ms) : 0, 10906
Debugger [candidate] (9.85 ms) : 0, 9850
Remote Config [baseline] (661.07 µs) : 0, 661
Remote Config [candidate] (663.867 µs) : 0, 664
Telemetry [baseline] (10.261 ms) : 0, 10261
Telemetry [candidate] (8.139 ms) : 0, 8139
ProfilingAgent [baseline] (103.164 ms) : 0, 103164
ProfilingAgent [candidate] (105.017 ms) : 0, 105017
Profiling [baseline] (103.188 ms) : 0, 103188
Profiling [candidate] (105.041 ms) : 0, 105041

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~9a188f8669, baseline=1.52.0-SNAPSHOT~562e53388e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (998.687 ms) : 0, 998687
Total [baseline] (8.609 s) : 0, 8608515
Agent [candidate] (995.253 ms) : 0, 995253
Total [candidate] (8.587 s) : 0, 8586842
section iast
Agent [baseline] (1.131 s) : 0, 1130793
Total [baseline] (9.311 s) : 0, 9310841
Agent [candidate] (1.131 s) : 0, 1130699
Total [candidate] (9.324 s) : 0, 9324054

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	998.687 ms	-
Agent	iast	1.131 s	132.106 ms (13.2%)
Total	tracing	8.609 s	-
Total	iast	9.311 s	702.326 ms (8.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	995.253 ms	-
Agent	iast	1.131 s	135.446 ms (13.6%)
Total	tracing	8.587 s	-
Total	iast	9.324 s	737.212 ms (8.6%)

gantt
    title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~9a188f8669, baseline=1.52.0-SNAPSHOT~562e53388e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.541 ms) : 0, 689541
BytebuddyAgent [candidate] (686.255 ms) : 0, 686255
GlobalTracer [baseline] (242.745 ms) : 0, 242745
GlobalTracer [candidate] (242.569 ms) : 0, 242569
AppSec [baseline] (30.526 ms) : 0, 30526
AppSec [candidate] (30.677 ms) : 0, 30677
Debugger [baseline] (6.029 ms) : 0, 6029
Debugger [candidate] (5.976 ms) : 0, 5976
Remote Config [baseline] (684.319 µs) : 0, 684
Remote Config [candidate] (684.276 µs) : 0, 684
Telemetry [baseline] (8.269 ms) : 0, 8269
Telemetry [candidate] (8.23 ms) : 0, 8230
section iast
BytebuddyAgent [baseline] (805.177 ms) : 0, 805177
BytebuddyAgent [candidate] (805.23 ms) : 0, 805230
GlobalTracer [baseline] (232.835 ms) : 0, 232835
GlobalTracer [candidate] (232.351 ms) : 0, 232351
AppSec [baseline] (30.466 ms) : 0, 30466
AppSec [candidate] (28.307 ms) : 0, 28307
Debugger [baseline] (5.745 ms) : 0, 5745
Debugger [candidate] (7.503 ms) : 0, 7503
Remote Config [baseline] (582.564 µs) : 0, 583
Remote Config [candidate] (592.341 µs) : 0, 592
Telemetry [baseline] (7.93 ms) : 0, 7930
Telemetry [candidate] (7.882 ms) : 0, 7882
IAST [baseline] (27.286 ms) : 0, 27286
IAST [candidate] (28.036 ms) : 0, 28036

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/fix-appsec-config-service-npe
git_commit_date	1752513413	1752567447
git_commit_sha	`562e533`	`9a188f8`
release_version	1.52.0-SNAPSHOT~562e53388e	1.52.0-SNAPSHOT~9a188f8669

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1752569003	1752569003
ci_job_id	1028533325	1028533325
ci_pipeline_id	70546546	70546546
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-swch0cmi 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-swch0cmi 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast_FULL:high_load	worse [+301.169µs; +908.518µs] or [+2.176%; +6.564%]	unstable [-51.116op/s; +23.179op/s] or [-15.188%; +6.887%]	14.446ms	322.594op/s	13.841ms	336.562op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~9a188f8669, baseline=1.52.0-SNAPSHOT~562e53388e
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.379 ms) : 4330, 4428
.   : milestone, 4379,
iast (9.394 ms) : 9237, 9550
.   : milestone, 9394,
iast_FULL (13.841 ms) : 13568, 14114
.   : milestone, 13841,
iast_GLOBAL (9.714 ms) : 9537, 9892
.   : milestone, 9714,
profiling (8.783 ms) : 8650, 8916
.   : milestone, 8783,
tracing (7.523 ms) : 7416, 7629
.   : milestone, 7523,
section candidate
no_agent (4.374 ms) : 4325, 4423
.   : milestone, 4374,
iast (9.141 ms) : 8992, 9291
.   : milestone, 9141,
iast_FULL (14.446 ms) : 14155, 14737
.   : milestone, 14446,
iast_GLOBAL (10.058 ms) : 9883, 10232
.   : milestone, 10058,
profiling (8.902 ms) : 8754, 9050
.   : milestone, 8902,
tracing (7.344 ms) : 7233, 7455
.   : milestone, 7344,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.379 ms [4.33 ms, 4.428 ms]	-
iast	9.394 ms [9.237 ms, 9.55 ms]	5.014 ms (114.5%)
iast_FULL	13.841 ms [13.568 ms, 14.114 ms]	9.462 ms (216.1%)
iast_GLOBAL	9.714 ms [9.537 ms, 9.892 ms]	5.335 ms (121.8%)
profiling	8.783 ms [8.65 ms, 8.916 ms]	4.404 ms (100.6%)
tracing	7.523 ms [7.416 ms, 7.629 ms]	3.143 ms (71.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.374 ms [4.325 ms, 4.423 ms]	-
iast	9.141 ms [8.992 ms, 9.291 ms]	4.767 ms (109.0%)
iast_FULL	14.446 ms [14.155 ms, 14.737 ms]	10.072 ms (230.3%)
iast_GLOBAL	10.058 ms [9.883 ms, 10.232 ms]	5.684 ms (129.9%)
profiling	8.902 ms [8.754 ms, 9.05 ms]	4.528 ms (103.5%)
tracing	7.344 ms [7.233 ms, 7.455 ms]	2.97 ms (67.9%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~9a188f8669, baseline=1.52.0-SNAPSHOT~562e53388e
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.677 ms) : 37372, 37982
.   : milestone, 37677,
appsec (47.038 ms) : 46624, 47451
.   : milestone, 47038,
code_origins (44.625 ms) : 44257, 44992
.   : milestone, 44625,
iast (45.853 ms) : 45444, 46261
.   : milestone, 45853,
profiling (49.483 ms) : 49006, 49960
.   : milestone, 49483,
tracing (44.767 ms) : 44393, 45140
.   : milestone, 44767,
section candidate
no_agent (37.942 ms) : 37636, 38248
.   : milestone, 37942,
appsec (47.887 ms) : 47465, 48309
.   : milestone, 47887,
code_origins (44.395 ms) : 44037, 44754
.   : milestone, 44395,
iast (44.911 ms) : 44523, 45299
.   : milestone, 44911,
profiling (48.222 ms) : 47777, 48667
.   : milestone, 48222,
tracing (45.255 ms) : 44882, 45629
.   : milestone, 45255,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.677 ms [37.372 ms, 37.982 ms]	-
appsec	47.038 ms [46.624 ms, 47.451 ms]	9.361 ms (24.8%)
code_origins	44.625 ms [44.257 ms, 44.992 ms]	6.948 ms (18.4%)
iast	45.853 ms [45.444 ms, 46.261 ms]	8.176 ms (21.7%)
profiling	49.483 ms [49.006 ms, 49.96 ms]	11.806 ms (31.3%)
tracing	44.767 ms [44.393 ms, 45.14 ms]	7.09 ms (18.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.942 ms [37.636 ms, 38.248 ms]	-
appsec	47.887 ms [47.465 ms, 48.309 ms]	9.945 ms (26.2%)
code_origins	44.395 ms [44.037 ms, 44.754 ms]	6.453 ms (17.0%)
iast	44.911 ms [44.523 ms, 45.299 ms]	6.969 ms (18.4%)
profiling	48.222 ms [47.777 ms, 48.667 ms]	10.28 ms (27.1%)
tracing	45.255 ms [44.882 ms, 45.629 ms]	7.313 ms (19.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/fix-appsec-config-service-npe
git_commit_date	1752513413	1752567447
git_commit_sha	`562e533`	`9a188f8`
release_version	1.52.0-SNAPSHOT~562e53388e	1.52.0-SNAPSHOT~9a188f8669

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1752569418	1752569418
ci_job_id	1028533327	1028533327
ci_pipeline_id	70546546	70546546
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-hpv1dtu7 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-hpv1dtu7 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~9a188f8669, baseline=1.52.0-SNAPSHOT~562e53388e
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.638 s) : 15638000, 15638000
.   : milestone, 15638000,
appsec (14.753 s) : 14753000, 14753000
.   : milestone, 14753000,
iast (18.708 s) : 18708000, 18708000
.   : milestone, 18708000,
iast_GLOBAL (17.97 s) : 17970000, 17970000
.   : milestone, 17970000,
profiling (15.314 s) : 15314000, 15314000
.   : milestone, 15314000,
tracing (14.85 s) : 14850000, 14850000
.   : milestone, 14850000,
section candidate
no_agent (15.467 s) : 15467000, 15467000
.   : milestone, 15467000,
appsec (14.752 s) : 14752000, 14752000
.   : milestone, 14752000,
iast (18.64 s) : 18640000, 18640000
.   : milestone, 18640000,
iast_GLOBAL (18.367 s) : 18367000, 18367000
.   : milestone, 18367000,
profiling (15.266 s) : 15266000, 15266000
.   : milestone, 15266000,
tracing (14.633 s) : 14633000, 14633000
.   : milestone, 14633000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.638 s [15.638 s, 15.638 s]	-
appsec	14.753 s [14.753 s, 14.753 s]	-885.0 ms (-5.7%)
iast	18.708 s [18.708 s, 18.708 s]	3.07 s (19.6%)
iast_GLOBAL	17.97 s [17.97 s, 17.97 s]	2.332 s (14.9%)
profiling	15.314 s [15.314 s, 15.314 s]	-324.0 ms (-2.1%)
tracing	14.85 s [14.85 s, 14.85 s]	-788.0 ms (-5.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.467 s [15.467 s, 15.467 s]	-
appsec	14.752 s [14.752 s, 14.752 s]	-715.0 ms (-4.6%)
iast	18.64 s [18.64 s, 18.64 s]	3.173 s (20.5%)
iast_GLOBAL	18.367 s [18.367 s, 18.367 s]	2.9 s (18.7%)
profiling	15.266 s [15.266 s, 15.266 s]	-201.0 ms (-1.3%)
tracing	14.633 s [14.633 s, 14.633 s]	-834.0 ms (-5.4%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~9a188f8669, baseline=1.52.0-SNAPSHOT~562e53388e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.411 ms) : 2361, 2461
.   : milestone, 2411,
iast (2.196 ms) : 2134, 2258
.   : milestone, 2196,
iast_GLOBAL (2.248 ms) : 2184, 2311
.   : milestone, 2248,
profiling (2.489 ms) : 2317, 2662
.   : milestone, 2489,
tracing (2.027 ms) : 1978, 2075
.   : milestone, 2027,
section candidate
no_agent (1.48 ms) : 1468, 1491
.   : milestone, 1480,
appsec (2.42 ms) : 2370, 2470
.   : milestone, 2420,
iast (2.205 ms) : 2143, 2267
.   : milestone, 2205,
iast_GLOBAL (2.237 ms) : 2174, 2299
.   : milestone, 2237,
profiling (2.058 ms) : 2007, 2109
.   : milestone, 2058,
tracing (2.023 ms) : 1974, 2071
.   : milestone, 2023,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.462 ms, 1.485 ms]	-
appsec	2.411 ms [2.361 ms, 2.461 ms]	937.277 µs (63.6%)
iast	2.196 ms [2.134 ms, 2.258 ms]	722.453 µs (49.0%)
iast_GLOBAL	2.248 ms [2.184 ms, 2.311 ms]	774.195 µs (52.5%)
profiling	2.489 ms [2.317 ms, 2.662 ms]	1.016 ms (68.9%)
tracing	2.027 ms [1.978 ms, 2.075 ms]	553.046 µs (37.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.48 ms [1.468 ms, 1.491 ms]	-
appsec	2.42 ms [2.37 ms, 2.47 ms]	940.154 µs (63.5%)
iast	2.205 ms [2.143 ms, 2.267 ms]	725.22 µs (49.0%)
iast_GLOBAL	2.237 ms [2.174 ms, 2.299 ms]	756.956 µs (51.2%)
profiling	2.058 ms [2.007 ms, 2.109 ms]	578.63 µs (39.1%)
tracing	2.023 ms [1.974 ms, 2.071 ms]	542.987 µs (36.7%)

jandro996 · 2025-07-14T05:22:47Z

task :dd-java-agent:appsec:test is failing in all test_base

jandro996

LGTM!

AlexeyKuznetsov-DD · 2025-07-14T13:03:02Z

dd-java-agent/appsec/src/main/java/com/datadog/appsec/config/AppSecConfigServiceImpl.java

@@ -320,6 +308,20 @@ private void distributeSubConfigurations(
    }
  }

+  private void maybeInitializeDefaultConfig() {


Suggestion: Maybe initializeDefaultConfigIfNeeded() would be a better name here?

The maybe pattern looks to be used here and there among the code base.
Not sure where it comes from, but that seems to spread to both common parts (agent) and products.

Yep, there are other examples even in the same class (e.g. maybeSubscribeConfigPolling), I think it's better to leave it as it is for consistency.

PerfectSlayer · 2025-07-15T07:14:47Z

Removing the second component to prevent duplicated entry from the changelog 😉

manuel-alvarez-alvarez · 2025-07-15T07:51:30Z

Removing the second component to prevent duplicated entry from the changelog 😉

Thanks!, I was in doubt when I added it.

manuel-alvarez-alvarez added type: bug Bug report and fix comp: asm waf Application Security Management (WAF) comp: remote config Configuration at Runtime labels Jul 11, 2025

manuel-alvarez-alvarez force-pushed the malvarez/fix-appsec-config-service-npe branch from e219fd4 to 0684458 Compare July 11, 2025 23:52

manuel-alvarez-alvarez marked this pull request as ready for review July 11, 2025 23:52

manuel-alvarez-alvarez requested a review from a team as a code owner July 11, 2025 23:52

manuel-alvarez-alvarez requested review from robertpi, sezen-datadog and jandro996 July 11, 2025 23:52

manuel-alvarez-alvarez force-pushed the malvarez/fix-appsec-config-service-npe branch from 0684458 to c228fda Compare July 12, 2025 10:22

manuel-alvarez-alvarez force-pushed the malvarez/fix-appsec-config-service-npe branch 2 times, most recently from 91aba31 to 4668cfd Compare July 14, 2025 08:26

jandro996 approved these changes Jul 14, 2025

View reviewed changes

AlexeyKuznetsov-DD reviewed Jul 14, 2025

View reviewed changes

PerfectSlayer removed the comp: remote config Configuration at Runtime label Jul 15, 2025

sezen-datadog approved these changes Jul 15, 2025

View reviewed changes

manuel-alvarez-alvarez requested review from AlexeyKuznetsov-DD and PerfectSlayer July 15, 2025 07:50

manuel-alvarez-alvarez force-pushed the malvarez/fix-appsec-config-service-npe branch from 4668cfd to dfd3d4a Compare July 15, 2025 08:06

Fix NPE in AppSecConfigServiceImpl

9a188f8

manuel-alvarez-alvarez force-pushed the malvarez/fix-appsec-config-service-npe branch from dfd3d4a to 9a188f8 Compare July 15, 2025 08:17

manuel-alvarez-alvarez merged commit 51532a8 into master Jul 15, 2025
543 checks passed

manuel-alvarez-alvarez deleted the malvarez/fix-appsec-config-service-npe branch July 15, 2025 09:30

github-actions bot added this to the 1.52.0 milestone Jul 15, 2025

manuel-alvarez-alvarez mentioned this pull request Jul 15, 2025

🍒 9165 - Fix NPE in AppSecConfigServiceImpl #9172

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix NPE in AppSecConfigServiceImpl #9165

Fix NPE in AppSecConfigServiceImpl #9165

manuel-alvarez-alvarez commented Jul 11, 2025

Uh oh!

pr-commenter bot commented Jul 12, 2025 •

edited

Loading

Uh oh!

jandro996 commented Jul 14, 2025

Uh oh!

jandro996 left a comment

Uh oh!

AlexeyKuznetsov-DD Jul 14, 2025

Uh oh!

PerfectSlayer Jul 15, 2025

Uh oh!

manuel-alvarez-alvarez Jul 15, 2025

Uh oh!

PerfectSlayer commented Jul 15, 2025

Uh oh!

manuel-alvarez-alvarez commented Jul 15, 2025

Uh oh!

Uh oh!

Uh oh!

Fix NPE in AppSecConfigServiceImpl #9165

Fix NPE in AppSecConfigServiceImpl #9165

Conversation

manuel-alvarez-alvarez commented Jul 11, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

jandro996 commented Jul 14, 2025

Uh oh!

jandro996 left a comment

Choose a reason for hiding this comment

Uh oh!

AlexeyKuznetsov-DD Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

manuel-alvarez-alvarez Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer commented Jul 15, 2025

Uh oh!

manuel-alvarez-alvarez commented Jul 15, 2025

Uh oh!

Uh oh!

Uh oh!

pr-commenter bot commented Jul 12, 2025 •

edited

Loading