feat(duckdb): adding duckdb integration #14232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmettbutler
requested changes
Aug 5, 2025
riotfile.py
Outdated
| command="pytest {cmdargs} tests/contrib/duckdb", | ||
| venvs=[ | ||
| Venv( | ||
| pys=select_pys(min_version="3.9", max_version="3.11"), |
There was a problem hiding this comment.
Is there a reason not to test against 3.12 and 3.13?
Comment on lines
71
to
72
| else: | ||
| tags[db.NAME] = database_path |
There was a problem hiding this comment.
This is redundant with line 65
|
|
||
| span = spans[0] | ||
| assert_is_measured(span) | ||
| assert span.service == "duckdb" |
There was a problem hiding this comment.
Multiple assertions on span attributes make this a good candidate to be converted to a snapshot test
| pin._clone(tracer=self.tracer).onto(conn) | ||
| return conn, self.tracer | ||
|
|
||
| def test_large_table_creation_performance(self): |
There was a problem hiding this comment.
These tests would be a good fit for the benchmarking platform, which provides stronger guarantees on resource usage. This directory contains examples of how to set up performance benchmarks that run in CI.
cweichen-dd
changed the title
cweichen-dd
changed the title
cweichen-dd
force-pushed
the
feature/duckdb-integration
branch
from
3717269 to
9dad1f0
Compare
- Add test snapshots for simple query, table operations, and error handling - Snapshots use ddtrace_subprocess_dir as base service name for Docker compatibility - Error handling test ignores error.stack field due to Python version differences
…e complex operations.
cweichen-dd
force-pushed
the
feature/duckdb-integration
branch
from
9dad1f0 to
6f2cf9e
Compare
cweichen-dd
force-pushed
the
feature/duckdb-integration
branch
from
bb8c5dd to
ecb7e8b
Compare
- Remove duplicate imports in patch.py (config, schematize_service_name) - Fix redundant database_path assignment - Clean up import structure following project standards Test Architecture Enhancements: - Convert comprehensive tests with multiple span assertions to snapshot tests - Add new snapshot tests: parameterized_queries, fetch_methods, service_name_override - Simplify comprehensive tests to focus on functional validation - Fix XFAIL issue by correcting snapshot test trace count expectations - Remove performance tests from regular test suite Benchmark Platform Integration: - Create complete benchmark scenario in benchmarks/duckdb/
tabgok
reviewed
Aug 15, 2025
| --- | ||
| features: | ||
| - | | ||
| Add DuckDB integration support with comprehensive tracing capabilities including query execution monitoring, performance metrics, and error handling for DuckDB ≥ 0.8.0. |
There was a problem hiding this comment.
0.8.0 doesn't match with the supported versions in patch.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Add Integration for DuckDB
Overview
This PR adds a new integration for DuckDB, providing tracing for database operations including queries, table operations, and bulk inserts.
Motivation
This was mostly an onboarding exercise for @cweichen-dd to get familiarity with the tracing codebase. DuckDB was chosen in conversation with @tabgok, as DuckDB is gaining adoption in data analytics and ML workloads.
Files Changed
Risks
Checklist
Reviewer Checklist