feat(profiling): Profile::{try_new2,try_add_sample2}
#1351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksComparisonBenchmark execution time: 2025-12-05 04:17:47 Comparing candidate commit e677b96 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1351 +/- ##
==========================================
+ Coverage 70.96% 71.12% +0.16%
==========================================
Files 400 403 +3
Lines 63691 64083 +392
==========================================
+ Hits 45199 45582 +383
- Misses 18492 18501 +9
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
morrisonlevi
commented
Nov 19, 2025
danielsn
reviewed
Nov 21, 2025
libdd-profiling/src/internal/profile/profiles_dictionary_translator.rs
Outdated
Show resolved
Hide resolved
Comment on lines
+21
to
+37
| #[derive(Copy, Clone, Debug, Default)] | ||
| pub struct Label<'a> { | ||
| pub key: StringId2, | ||
|
|
||
| /// At most one of `.str` and `.num` should not be empty. | ||
| pub str: &'a str, | ||
| pub num: i64, | ||
|
|
||
| /// Should only be present when num is present. | ||
| /// Specifies the units of num. | ||
| /// Use arbitrary string (for example, "requests") as a custom count unit. | ||
| /// If no unit is specified, consumer may apply heuristic to deduce the unit. | ||
| /// Consumers may also interpret units like "bytes" and "kilobytes" as memory | ||
| /// units and units like "seconds" and "nanoseconds" as time units, | ||
| /// and apply appropriate unit conversions to these. | ||
| pub num_unit: &'a str, | ||
| } |
Contributor
There was a problem hiding this comment.
Would it make sense to use Rust enums here to enforce this?
Contributor
Author
There was a problem hiding this comment.
Some of the code does model it this way, such as the internal::Label. But the api2::Label is meant to be more similar to api::Label for easier adoption, and it does not use enums because it more closely mirrors the FFI.
libdd-profiling/src/internal/profile/profiles_dictionary_translator.rs
Outdated
Show resolved
Hide resolved
libdd-profiling/src/internal/profile/profiles_dictionary_translator.rs
Outdated
Show resolved
Hide resolved
Comment on lines
58
to
61
| let internal_id = functions.dedup(function); | ||
| self.functions.try_reserve(1)?; | ||
| self.functions.insert(set_id, internal_id); | ||
| Ok(internal_id) |
Contributor
There was a problem hiding this comment.
so this both functions and self.functions? Why do we need both
Contributor
Author
There was a problem hiding this comment.
One is the internal function "table" and the other is a HashMap that converts from the ProfilesDictionary IDs into the internal IDs.
libdd-profiling/src/internal/profile/profiles_dictionary_translator.rs
Outdated
Show resolved
Hide resolved
morrisonlevi
force-pushed
the
levi/try_add_sample2
branch
from
342cef5 to
19bb0ef
Compare
danielsn
reviewed
Dec 3, 2025
Comment on lines
+38
to
+43
| locations.push(Location2 { | ||
| mapping: MappingId2::default(), | ||
| function: frame.function, | ||
| address: 0, | ||
| line: frame.line_number as i64, | ||
| }); |
Contributor
There was a problem hiding this comment.
Would this make sense as a .into() function
libdd-profiling/src/internal/profile/profiles_dictionary_translator.rs
Outdated
Show resolved
Hide resolved
danielsn
approved these changes
Dec 5, 2025
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit f6d7637: What to do next?
|
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: rejected
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds two new methods to
libdd_profiling::internal::Profilewith supporting types:Profile::try_new2Profile::try_add_sample2Motivation
These APIs together are faster than the versions that aren't suffixed with 2.
Additional Notes
This doesn't add the FFI API yet, that's coming next.
How to test the change?
Everything should be the same. There is a benchmark you can run to compare some basic API level tests. Here is what I got locally on my M1:
In this basic benchmarking test, it's roughly 3x faster.