Allow dropping a user not in the server #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle when their Member data doesn't exist
kevinlul
approved these changes
Jan 31, 2023
|
While testing, the schema edit caused issues on my end, so we're gonna have to figure that out when we merge |
|
Is synchronize bad at mutating SQLite tables? |
kevinlul
approved these changes
Jan 31, 2023
|
synchronize will be fine as long as there is no data in the deck table, due to the non-null constraint on the new column |
Cannot error, guild will be guaranteed cached, left users will just fall back to the user data
kevinlul
reviewed
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle when their Member data doesn't exist
Relevant to #465, though doesn't close it entirely
Checklist