GRIDEDIT-2293 Refactor inner boundary polygons - #278
Merged
Conversation
BillSenior
changed the title
BillSenior
force-pushed
the
feature/GRIDEDIT-2293_separate_polygon_loops
branch
from
August 13, 2026 14:11
2a5c6a6 to
9ab43aa
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates MeshKernelPy’s polygon-boundary behavior expectations and clarifies the Python API documentation around inner boundary polygons.
Changes:
- Updates the expected coordinate ordering in the
mesh2d_get_mesh_boundaries_as_polygonstest. - Refines the docstring text for
mesh2d_get_mesh_inner_boundaries_as_polygons.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/test_mesh2d_basics.py |
Adjusts expected boundary polygon coordinates for a basic mesh boundary test. |
meshkernel/meshkernel.py |
Updates docstring wording for the inner-boundary polygons API. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.