Skip to content

GRIDEDIT-2293 Refactor inner boundary polygons #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BillSenior merged 3 commits into from
Aug 17, 2026
Merged

GRIDEDIT-2293 Refactor inner boundary polygons #278

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f238463
GRIDEDIT-2293 Update comment
BillSenior Aug 6, 2026
9ab43aa
GRIDEDIT-2293 Fixed unit test, reordered the boundary to anti-clockwise
BillSenior Aug 6, 2026
633b60b
GRIDEDIT-2293 Updated comment
BillSenior Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion meshkernel/meshkernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ def mesh2d_get_mesh_inner_boundaries_as_polygons(self) -> GeometryList:
"""Gets the inner boundary polygons from the MeshKernel.

Returns:
Mesh2d: A copy of the inner boundary polygons.
Mesh2d: A sequence of points describing the inner boundary polygons of the mesh.
"""
Comment thread
BillSenior marked this conversation as resolved.

c_geometry_list_dimension = c_int()
Expand Down
4 changes: 2 additions & 2 deletions tests/test_mesh2d_basics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,12 +1198,12 @@ def test_mesh2d_get_mesh_boundaries_as_polygons(meshkernel_with_mesh2d: MeshKern
mesh_boundary = mk.mesh2d_get_mesh_boundaries_as_polygons()

assert_array_equal(
np.array([0.0, 1.0, 2.0, 2.0, 2.0, 1.0, 0.0, 0.0, 0.0], dtype=np.double),
mesh_boundary.x_coordinates,
np.array([0.0, 0.0, 0.0, 1.0, 2.0, 2.0, 2.0, 1.0, 0.0], dtype=np.double),
)
Comment thread
BillSenior marked this conversation as resolved.
assert_array_equal(
mesh_boundary.y_coordinates,
np.array([0.0, 1.0, 2.0, 2.0, 2.0, 1.0, 0.0, 0.0, 0.0], dtype=np.double),
np.array([0.0, 0.0, 0.0, 1.0, 2.0, 2.0, 2.0, 1.0, 0.0], dtype=np.double),
)


Expand Down
Loading